-
Notifications
You must be signed in to change notification settings - Fork 32
Return the last read key when doing range reads #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasagredo
wants to merge
1
commit into
main
Choose a base branch
from
js/lmdb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+349
−247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I plan on merging this as a PR stack:
This is a graph of the dependencies of the PRs
|
efdf425
to
2421e01
Compare
80421ad
to
7f77886
Compare
This was referenced Aug 25, 2025
Merged
7f77886
to
8aa430b
Compare
8aa430b
to
9fca513
Compare
9fca513
to
bafbd1c
Compare
bafbd1c
to
6748c08
Compare
6748c08
to
bcc5b88
Compare
bcc5b88
to
26f08d1
Compare
This was referenced Sep 1, 2025
26f08d1
to
3269dc7
Compare
55e952e
to
a3dc493
Compare
LSM trees use an ordering different than the Haskell `Ord`. This commit enriches the type returned by range reads so that the maximal key is returned, which is then given back to the next iteration of the range reading loop.
3269dc7
to
66c3d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.