Skip to content

Conversation

@jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Aug 22, 2025

No description provided.

@jasagredo
Copy link
Contributor Author

jasagredo commented Aug 22, 2025

I plan on merging this as a PR stack:

This is a graph of the dependencies of the PRs

            ┌─────┐
            │#1653│
            └──┬──┘
               │
            ┌──▼──┐
            │#1652│
            └──┬──┘
               │
            ┌──▼──┐
            │#1603│
            └──┬──┘
               │
               │
            ┌──▼──┐
            │#1572│
            └─────┘
               │
   ┌───────┬───┴───┬───────┐
┌──▼──┐ ┌──▼──┐ ┌──▼──┐ ┌──▼──┐
│#1640│ │#1643│ │#1641│ │#1644│
└─────┘ └─────┘ └─────┘ └─────┘

@jasagredo jasagredo force-pushed the js/forkers branch 2 times, most recently from efdf425 to 2421e01 Compare August 25, 2025 09:18
@jasagredo jasagredo changed the title Return the last read key in LMDB backend Return the last read key when doing range reads Aug 25, 2025
@jasagredo jasagredo marked this pull request as ready for review August 25, 2025 10:31
@jasagredo jasagredo changed the base branch from js/forkers to js/snapshot-manager August 25, 2025 10:31
@jasagredo jasagredo force-pushed the js/snapshot-manager branch from 80421ad to 7f77886 Compare August 25, 2025 10:58
@jasagredo jasagredo force-pushed the js/snapshot-manager branch from 7f77886 to 8aa430b Compare August 25, 2025 13:36
@jasagredo jasagredo force-pushed the js/snapshot-manager branch from 8aa430b to 9fca513 Compare August 25, 2025 15:18
@jasagredo jasagredo force-pushed the js/snapshot-manager branch from 9fca513 to bafbd1c Compare August 26, 2025 09:23
@jasagredo jasagredo force-pushed the js/snapshot-manager branch from bafbd1c to 6748c08 Compare August 26, 2025 11:23
LSM trees use an ordering different than the Haskell `Ord`. This commit enriches
the type returned by range reads so that the maximal key is returned, which is
then given back to the next iteration of the range reading loop.
@jasagredo jasagredo enabled auto-merge September 3, 2025 10:57
Copy link
Contributor

@fraser-iohk fraser-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only minor taste-related concern is returning a tuple that's a bit contextless instead of some kind of data type with two fields, but otherwise happy with this

@jasagredo jasagredo added this pull request to the merge queue Sep 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 3, 2025
@jasagredo jasagredo added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit cc9a901 Sep 3, 2025
17 of 18 checks passed
@jasagredo jasagredo deleted the js/lmdb branch September 3, 2025 20:13
@jasagredo jasagredo moved this to 👀 In review in Consensus Team Backlog Sep 19, 2025
@jasagredo jasagredo moved this from 👀 In review to ✅ Done in Consensus Team Backlog Sep 19, 2025
@jasagredo jasagredo self-assigned this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants