Skip to content

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Aug 26, 2025

Node removed support for unitary chains long ago, so it becomes useless to be able to analyze those.

@jasagredo
Copy link
Contributor Author

jasagredo commented Aug 26, 2025

I plan on merging this as a PR stack:

This is a graph of the dependencies of the PRs

                 ┌─────┐       
                 │#1653│       
                 └──┬──┘       
                    │          
                 ┌──▼──┐       
                 │#1652│       
                 └──┬──┘       
                    │          
                 ┌──▼──┐       
                 │#1603│       
                 └──┬──┘       
                    │          
               ┌────┴─────┐    
            ┌──▼──┐    ┌──▼──┐ 
            │#1572│    │#1647│ 
            └─────┘    └─────┘ 
               │               
   ┌───────┬───┴───┬───────┐   
┌──▼──┐ ┌──▼──┐ ┌──▼──┐ ┌──▼──┐
│#1640│ │#1643│ │#1641│ │#1644│
└─────┘ └─────┘ └─────┘ └─────┘

Copy link
Contributor

@geo2a geo2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to remove

data BlockType blk where
ByronBlockType :: BlockType ByronBlockHFC
ShelleyBlockType :: BlockType (ShelleyBlockHFC (Consensus.TPraos StandardCrypto) ShelleyEra)

@jasagredo jasagredo force-pushed the js/remove-shelley-byron branch 2 times, most recently from 05bdb97 to 450a323 Compare August 29, 2025 09:53
@jasagredo jasagredo force-pushed the js/remove-shelley-byron branch from 450a323 to 773fa5c Compare August 29, 2025 09:57
@jasagredo jasagredo requested a review from amesgen August 29, 2025 09:57
@jasagredo jasagredo added this pull request to the merge queue Sep 1, 2025
Merged via the queue into main with commit 55f7524 Sep 1, 2025
16 of 17 checks passed
@jasagredo jasagredo deleted the js/remove-shelley-byron branch September 1, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants