forked from JabRef/jabref
-
Notifications
You must be signed in to change notification settings - Fork 15
Apply spring java format #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
Author
|
The bad formatting was already posted 2023 at #663 (comment) - but I totally forgot about it. |
Member
Author
|
note that google java format also cannot be used, because it does not support Markdown comments: google/google-java-format#1193 |
Member
Author
|
spotless is still no option: diffplug/spotless#2599 |
Member
Author
|
IntelliJ can use Eclipse formatter: https://github.com/krasa/EclipseCodeFormatter |
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 19, 2025
JabRef/jabref-koppor#716 jabgui/src/main/java/org/jabref/gui/groups/GroupNodeViewModel.java jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 19, 2025
JabRef/jabref-koppor#716 jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java within method addSelectedEntries()
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 20, 2025
JabRef/jabref-koppor#716 jabgui/src/main/java/org/jabref/gui/importer/NewEntryAction.java
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 20, 2025
JabRef/jabref-koppor#716 org.jabref.gui.ClipBoardManager
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 20, 2025
JabRef/jabref-koppor#716 jablib/src/main/java/org/jabref/logic/crawler/StudyRepository.java
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 21, 2025
JabRef/jabref-koppor#716 jabgui/src/main/java/org/jabref/gui/maintable/ColumnPreferences.java jabgui/src/main/java/org/jabref/gui/maintable/MainTableColumnModel.java jabgui/src/main/java/org/jabref/gui/preferences/network/NetworkTab.java jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java jabgui/src/main/java/org/jabref/gui/groups/GroupTreeView.java jabgui/src/main/java/org/jabref/gui/preferences/ai/AiTabViewModel.java
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 21, 2025
JabRef/jabref-koppor#716 jabgui/src/main/java/org/jabref/gui/desktop/os/NativeDesktop.java jablib/src/main/java/org/jabref/logic/importer/SearchBasedParserFetcher.java jablib/src/main/java/org/jabref/logic/importer/Importer.java jablib/src/main/java/org/jabref/model/database/BibDatabaseContext.java
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 21, 2025
JabRef/jabref-koppor#716 jabgui/src/main/java/org/jabref/gui/openoffice/Bootstrap.java (#976)
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 21, 2025
JabRef/jabref-koppor#716 org.jabref.gui.openoffice.OOBibBase (#976)
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 21, 2025
JabRef/jabref-koppor#716 jablib/src/test/java/org/jabref/logic/git/GitSyncServiceTest.java
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Follow-up to #672
I think spring-javaformat is our last chance if we don't want to configure our own rules. The plugin is automatically activated in IntelliJ. For the code style, see https://github.com/spring-projects/spring-framework/wiki/Code-Style
spaces instead of tabs are activated.
We still need
We need to accept that
elsestarts on the "first" column. ("Kernighan and Ritchie style") -> https://github.com/spring-projects/spring-framework/wiki/Code-Style#block-like-constructs-kr-styleThis is OK for me.
If this new coe style is OK, setup .git blame ignore - as outlined at JabRef#10646 (comment). Do a merge commit, not a squash-merge.
Steps to test
Open the code in IntelliJ
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)