Change AbstractCoordinatePoint to not be a FieldVector by oschulz · Pull Request #489 · JuliaPhysics/SolidStateDetectors.jl

oschulz · 2025-05-16T12:12:09Z

Corresponds to mathematically cleaner "affine vs. linear" language.

src/ConstructiveSolidGeometry/PointsAndVectors/Points.jl

devenv/README.md

devenv/cpu/Project.toml

Implement proper math for affine frames, Refactor code base where necessary.

fhagemann

Can we PLEASE first make a release with the current main before merging this in case this messes some things up that are not covered by the tests?

oschulz · 2025-06-17T15:03:07Z

Can we PLEASE first make a release with the current main before merging this in case this messes some things up that are not covered by the tests?

Sure, registering now:

6596756

JuliaRegistries/General#133070

fhagemann

Thanks

Also scale default marker size automatically. Need to plot points with units in samplesurface mode now too.

Previous versions require pos in DetectorHit to be an AbstractVector

src/ConstructiveSolidGeometry/VolumePrimitives/RegularPrism.jl

Many recent changes that might need re-reviewing

fhagemann · 2025-10-09T22:56:23Z

I'm deactivating the Downgrade tests on julia-1.12 for now, there seems to be some issues that are unrelated to the changes in this PR.

fhagemann · 2025-10-11T04:11:25Z

For the release notes for 0.11.0:
can someone write out what the breaking changes are and what exactly changed in this PR?

This reverts commit 3425c2d.

fhagemann · 2025-10-11T20:22:50Z

ext/SolidStateDetectorsLegendHDF5IOExt.jl


        # LH5 can't handle CartesianPoint, turn positions into CartesianVectors which will be saved as SVectors
-        pos_vec = VectorOfVectors([p .- Ref(cartesian_zero) for p in mcevents_sub.pos])
+        pos_vec = VectorOfVectors([[CartesianPoint(p...) - cartesian_zero for p in ps] for ps in mcevents_sub.pos])


Instead of defining a new cartesian_zero, I changed this commit to convert whatever p is to a CartesianPoint first, to then subtract the original cartesian_zero to get a CartesianVector that can be saved to a file by LegendHDF5IO.

fhagemann

I would suggest merging this into main and then making an issue with all the things that still have to be done for the 0.11.0 release in a separate issue (and separate PRs), including drafting a release note with breaking changes.

oschulz · 2025-10-13T06:58:48Z

I would suggest merging this into main and then making an issue with all the things that still have to be done for the 0.11.0 release in a separate issue (and separate PRs), including drafting a release note with breaking changes.

Sounds good to me.

oschulz force-pushed the point-types branch from 0ffc488 to 25f5a33 Compare May 16, 2025 12:12

fhagemann marked this pull request as draft May 16, 2025 23:23

fhagemann reviewed May 17, 2025

View reviewed changes

src/ConstructiveSolidGeometry/PointsAndVectors/Points.jl Outdated Show resolved Hide resolved

oschulz force-pushed the point-types branch 4 times, most recently from 4ad755a to c787b66 Compare May 17, 2025 23:04

fhagemann reviewed Jun 12, 2025

View reviewed changes

devenv/README.md Show resolved Hide resolved

fhagemann reviewed Jun 17, 2025

View reviewed changes

devenv/cpu/Project.toml Show resolved Hide resolved

oschulz force-pushed the point-types branch from 07839be to 62b4523 Compare June 17, 2025 14:42

oschulz requested a review from RicardaRiepen June 17, 2025 14:49

oschulz marked this pull request as ready for review June 17, 2025 14:49

Change AbstractCoordinatePoint to not be a FieldVector

e2d1f49

Implement proper math for affine frames, Refactor code base where necessary.

oschulz force-pushed the point-types branch from 62b4523 to e2d1f49 Compare June 17, 2025 14:55

fhagemann requested changes Jun 17, 2025

View reviewed changes

fhagemann reviewed Jun 17, 2025

View reviewed changes

fhagemann previously approved these changes Jun 17, 2025

View reviewed changes

RicardaRiepen approved these changes Jun 17, 2025

View reviewed changes

oschulz added 7 commits June 18, 2025 20:05

Export cartesian_zero

9d5dff5

Improve cartesian points and vectors and add unit handling

3f558b8

Support units in CartesianPoint Plots recipes

71f1435

Also scale default marker size automatically. Need to plot points with units in samplesurface mode now too.

Require RadiationDetectorSignals v0.3.10

ca520bf

Previous versions require pos in DetectorHit to be an AbstractVector

Make run_geant4_simulation should return points for pos

6b84ab4

Require ArraysOfArrays in docs

50acfac

Adapt Geant4 example in docs to changes in point types

8a1112b

oschulz force-pushed the point-types branch from 37e48cf to 8a1112b Compare June 18, 2025 20:02

fhagemann reviewed Jun 19, 2025

View reviewed changes

src/ConstructiveSolidGeometry/VolumePrimitives/RegularPrism.jl Outdated Show resolved Hide resolved

oschulz added 2 commits June 19, 2025 11:11

Improve zero and iszero for coordinate points and vectors

aa80638

Use iszero and isone instead of comparing with one and zero of value

af86849

fhagemann added this to the v0.11.0 milestone Oct 9, 2025

fhagemann marked this pull request as ready for review October 9, 2025 15:37

fhagemann force-pushed the point-types branch from e0bda75 to ac08c04 Compare October 10, 2025 16:59

claudiaalvgar and others added 2 commits October 11, 2025 12:58

Fix for failing tests

d37c448

Revert "Disallow Geant4_julia_jll v0.2.3, it's broken"

d4df13f

This reverts commit 3425c2d.

fhagemann force-pushed the point-types branch from ac08c04 to 27c8b07 Compare October 11, 2025 20:21

fhagemann reviewed Oct 11, 2025

View reviewed changes

Merge main into point-types

7adfe48

fhagemann force-pushed the point-types branch from 3188c33 to 087cb82 Compare October 11, 2025 20:49

Run Downgrade tests explicitly on julia-1.12

b6cdbf6

fhagemann force-pushed the point-types branch from 087cb82 to b6cdbf6 Compare October 12, 2025 00:33

fhagemann approved these changes Oct 13, 2025

View reviewed changes

fhagemann merged commit 020a266 into main Oct 16, 2025
10 of 12 checks passed

fhagemann mentioned this pull request Oct 16, 2025

Release v0.11.0 #543

Closed

11 tasks

fhagemann linked an issue Oct 27, 2025 that may be closed by this pull request

Release v0.11.0 #543

Closed

11 tasks

This was referenced Oct 27, 2025

Fully support CartesianPoints with units #183

Closed

Plotting CartesianPoints does not seem to be correct #550

Closed

Fix plotting CartesianPoint with correct units #551

Merged

This was referenced Oct 28, 2025

Operations with CartesianPoints not supported and causing errors #552

Closed

Use vectors instead of points to move_charges_inside_semiconductor #553

Merged

This was referenced Nov 4, 2025

Fix plotting methods with new CartesianPoint implementation #558

Merged

Add option to split MC-table events into separate events by time #559

Merged

claudiaalvgar mentioned this pull request Nov 10, 2025

Create new datatype when saving CartesianPoint to HDF5 using LegendHDF5IO #560

Merged

fhagemann deleted the point-types branch November 28, 2025 20:56

claudiaalvgar mentioned this pull request Dec 4, 2025

Test Coverage for CartesianPoint: Part 2 #571

Merged

fhagemann referenced this pull request Feb 18, 2026

Increase package version to v0.11.0

3f6997a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change AbstractCoordinatePoint to not be a FieldVector#489

Change AbstractCoordinatePoint to not be a FieldVector#489
fhagemann merged 23 commits intomainfrom
point-types

oschulz commented May 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fhagemann left a comment

Uh oh!

oschulz commented Jun 17, 2025

Uh oh!

fhagemann left a comment

Uh oh!

Uh oh!

fhagemann commented Oct 9, 2025

Uh oh!

fhagemann commented Oct 11, 2025

Uh oh!

fhagemann Oct 11, 2025

Uh oh!

fhagemann left a comment

Uh oh!

oschulz commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

oschulz commented May 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fhagemann left a comment

Choose a reason for hiding this comment

Uh oh!

oschulz commented Jun 17, 2025

Uh oh!

fhagemann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fhagemann commented Oct 9, 2025

Uh oh!

fhagemann commented Oct 11, 2025

Uh oh!

fhagemann Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

fhagemann left a comment

Choose a reason for hiding this comment

Uh oh!

oschulz commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants