Skip to content

Conversation

@franknoirot
Copy link
Contributor

@franknoirot franknoirot commented Dec 31, 2025

Thanks @nadr0 for all the help thinking about this.

  1. Introduces an "archive" path within the Electron "userData" location.
  2. Creates a new window.electron.move() function that uses fs.rename to move files to and from this archive when deleting and restoring, with fallback behaviors
  3. Wires up new systemIOMachine workflows recursiveMove and recursiveMoveAndNavigate (created by mostly miming deleteFileOrFolder)
  4. Swaps out deletion workflows in ProjectExplorer for archive ones
  5. Adds a new fsEffectExtension to CodeMirror which makes these archive workflows reversible using it's awesome invertedEffects Facet

Demo

@franknoirot franknoirot requested a review from a team as a code owner December 31, 2025 07:38
@vercel
Copy link

vercel bot commented Dec 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
modeling-app Ready Ready Preview, Comment Jan 9, 2026 8:53pm

@franknoirot franknoirot force-pushed the franknoirot/8306/undoable-fs branch from c0c017f to 9fd2746 Compare December 31, 2025 07:41
@franknoirot franknoirot marked this pull request as draft December 31, 2025 07:41
@franknoirot
Copy link
Contributor Author

Gonna mark this as draft until I can get some unit and E2E tests together next week.

@max-mrgrsk
Copy link
Contributor

wow this is dope! This makes me think it would be cool to have a trash bin in the app. Will be appreciated by the web users.

@franknoirot
Copy link
Contributor Author

wow this is dope! This makes me think it would be cool to have a trash bin in the app. Will be appreciated by the web users.

@max-mrgrsk yeah once we have web FS landed hooking this up to it will be pretty trivial. Then we can provide a way for users, whether desktop or web, to browse their archive and restore lost files.

@franknoirot franknoirot force-pushed the franknoirot/8306/undoable-fs branch from cf4a1aa to 50b1091 Compare January 9, 2026 18:29
@franknoirot franknoirot force-pushed the franknoirot/8306/undoable-fs branch 2 times, most recently from 1665af0 to 0a7ce4c Compare January 9, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add proper move to File Explorer

3 participants