-
Notifications
You must be signed in to change notification settings - Fork 98
Make deletions through the Project Explorer archived in UserData, and un/redoable #9508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
c0c017f to
9fd2746
Compare
|
Gonna mark this as draft until I can get some unit and E2E tests together next week. |
|
wow this is dope! This makes me think it would be cool to have a trash bin in the app. Will be appreciated by the web users. |
b6c0305 to
7ed91a9
Compare
@max-mrgrsk yeah once we have web FS landed hooking this up to it will be pretty trivial. Then we can provide a way for users, whether desktop or web, to browse their archive and restore lost files. |
7ed91a9 to
0279fe1
Compare
6f7b69a to
4410869
Compare
3130840 to
2ac0da1
Compare
2ac0da1 to
c689b42
Compare
c689b42 to
cf4a1aa
Compare
This signal wasn't being reacted to here since we memoized this component in #9378
cf4a1aa to
50b1091
Compare
1665af0 to
0a7ce4c
Compare
0a7ce4c to
b0dfa1c
Compare
First pass at extension
b0dfa1c to
3ae8577
Compare
Thanks @nadr0 for all the help thinking about this.
window.electron.move()function that usesfs.renameto move files to and from this archive when deleting and restoring, with fallback behaviorsrecursiveMoveandrecursiveMoveAndNavigate(created by mostly mimingdeleteFileOrFolder)fsEffectExtensionto CodeMirror which makes these archive workflows reversible using it's awesomeinvertedEffectsFacetDemo