Edit collect logs form cypress refactor

[asirvadAbrahamVarghese]

PR that refactors Cypress tests for Collect Logs edit form also include review comments changes from #9508

@miq-bot assign @jrafanie
@miq-bot add-label cypress
@miq-bot add-label test

[asirvadAbrahamVarghese]

This is also prone to sporadic server-related failures, as we’ve seen with the schedules form:

[asirvadAbrahamVarghese]

• a5142fd

comment - When #9504 gets merged, we can use the helper function here.
comment - Note, checking for "saved" in the message is probably all we need.
comment - Also, we can merge this now and open a new PR to update to the helper function cy.expectFlash('success', 'saved')

• e9b091e

comment - Note, the hardcoded 2 in these intercepts here and the tree select feel brittle to me. I wonder if we need to be this precise with the intercepts. Can we use glob pattern matching or are there similar POSTs that occur that we have to avoid intercept/waiting on?

[jrafanie]

This is also prone to sporadic server-related failures, as we’ve seen with the schedules form:

sorry, I can't read the error in the screenshot. Is that the session issue losing the tree info? undefined method to_sym for nil or undefined method split for nil: #9515?

[asirvadAbrahamVarghese]

sorry, I can't read the error in the screenshot. Is that the session issue losing the tree info? undefined method to_sym for nil or undefined method split for nil

Yes a similar one, Data undefined method downcase' for nil [ops/accordion_select] (replaced the screenshot)

[miq-bot]

Checked commits asirvadAbrahamVarghese/manageiq-ui-classic@1d5b2a8~...a5142fd with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

[jrafanie]

sorry, I can't read the error in the screenshot. Is that the session issue losing the tree info? undefined method to_sym for nil or undefined method split for nil

Yes a similar one, Data undefined method downcase' for nil [ops/accordion_select] (replaced the screenshot)

Ok, I still have to get back to that one but I'm pretty sure it's a session race condition where one puma thread overwrites another threads session update.

[jrafanie]

FYI, I just learned that cypress will retry the last query it did until the timeout. If you do cy.contains(selector, text), it will retry the whole thing and not just the contains call. If we rerender things and update the DOM element, we should probably avoid doing cy.get(selector).contains(string) as we may get the element before it's updated in the DOM. Instead, we should use cy.contains(selector+sub element, string)

https://www.youtube.com/watch?v=VSIaDbv4GyE

See also:
https://youtu.be/AhgkBjOF5Ts?t=1530

[asirvadAbrahamVarghese]

I am thinking about making this as a new custom command, like I mentioned here

Cypress.Commands.add('getFormFooterButtonByType', (type, name) => {
  return cy.contains(`#main-content .bx--btn-set button[type="${type}"]`, name);
});

[asirvadAbrahamVarghese]

PR with selector commands for common form elements: #9537

[jrafanie]

We might want to extract this to a custom command for use in other tests.

[asirvadAbrahamVarghese]

Requires #9531 to be merged for further refactor

[jrafanie]

Requires #9531 to be merged for further refactor

DONE, feel free to continue on with this one.

[jrafanie]

@asirvadAbrahamVarghese can you look at the failing test in the collect logs tests?

[asirvadAbrahamVarghese]

Todo in a follow up PR:

• Use form element selector commands from: Add custom commands for selecting form elements #9537
• Extract shared intercept-and-wait logic that handles duplicate intercepts as recommended here
• Add more detailed component testing if considered required per [WIP] - Added automated tests with cypress for Namespace form #9517

[jrafanie]

LGTM. I always notice how things are named. We might want different names for some of these specific functions for collect logs but since I don't have better suggestions, let's just go forward and rename if we find better ideas.