-
Notifications
You must be signed in to change notification settings - Fork 6
Objectathon Example Vector and String Handling #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2dcd3e0 to
10042c6
Compare
e9f92f2 to
cd7900e
Compare
rlpratt12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with some minor rework this could be super streamlined. The only exception is implementing that template specialization of convertFromString for BT::Any. I'll take a look at how to do that and report back.
|
@davetcoleman I committed the new version I was thinking of, see what you think. (we can always revert the commit if you don't like it).
|
952ebd4 to
245cab9
Compare
b03c65d to
7b8a64e
Compare
|
@rlpratt12 i tweaked and built upon your changes a bit - separating out the command to paste into the terminal and clarifying you might need to use moveit_pro dev and added back asmiov's laws. ready for approval |
| <Control ID="Sequence" name="Test Some Vector Operations"> | ||
| <Action | ||
| ID="Script" | ||
| code="string1 := 'Copy and run the following command in your "moveit_pro dev" terminal, then rerun this Objective to get the secret message.'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to be in a dev terminal, any terminal will work. (Unless they've changed their DDS config, in which case they should know the messaging restrictions anyways).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't work on my machine because i do not have ROS installed on the host computer, which is not a requirement of MoveIt Pro to do.
IDK if moveit_pro shell is better, i can never remember the difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I forgot about the case of not having ROS installed at all. I'm good with saying shell then so it always works, which is more appropriate than dev.
|
@rlpratt12 looking for an Approval here |
Co-authored-by: Richard Pratt <[email protected]>
Objectathon Example Vector and String Handling
Adds examples for Behaviors:
ReadTextFileAsString
PublishString
GetSizeOfVector
InsertInVector
RemoveFromVector
ReplaceInVector
6 Total!