Skip to content

Conversation

@cduck
Copy link
Contributor

@cduck cduck commented Oct 22, 2025

I double-checked that these are the correct gates. I made sure that each one results in first an (optional) Z rotation then an (optional) X or Y rotation.

@cduck cduck requested a review from johnzl-777 October 22, 2025 22:29
@johnzl-777
Copy link
Contributor

Thank you! Let me update the rest of the tests and then I can backport to 0.7 of circuit 👍

@cduck
Copy link
Contributor Author

cduck commented Oct 23, 2025

Sorry. Seems the build is failing.

@johnzl-777
Copy link
Contributor

No worries! Just glad we can take care of the issue. I believe the failing CI is also because there are some fixes waiting to be backported but I can at least make sure the rest of the tests are set 👍

@cduck
Copy link
Contributor Author

cduck commented Oct 23, 2025

I'm fixing the CI now. Several of the problems were my fault.

Copy link
Contributor

@johnzl-777 johnzl-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @rafaelha has already addressed the salient points (:

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
9497 8379 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/squin/rewrite/U3_to_clifford.py 92% 🟢
TOTAL 92% 🟢

updated for commit: e5094a9 by action🐍

@johnzl-777 johnzl-777 merged commit 58a91e2 into main Oct 27, 2025
11 checks passed
@johnzl-777 johnzl-777 deleted the cduck/clean-gates branch October 27, 2025 20:32
@johnzl-777
Copy link
Contributor

@cduck Should this live in release-0-7 as well? This doesn't seem particularly difficult to backport

@cduck
Copy link
Contributor Author

cduck commented Oct 28, 2025

@cduck Should this live in release-0-7 as well? This doesn't seem particularly difficult to backport

Sure, but not critical @johnzl-777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants