-
Notifications
You must be signed in to change notification settings - Fork 1
Clean up squin gate generation #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you! Let me update the rest of the tests and then I can backport to 0.7 of circuit 👍 |
|
Sorry. Seems the build is failing. |
|
No worries! Just glad we can take care of the issue. I believe the failing CI is also because there are some fixes waiting to be backported but I can at least make sure the rest of the tests are set 👍 |
|
I'm fixing the CI now. Several of the problems were my fault. |
johnzl-777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @rafaelha has already addressed the salient points (:
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
@cduck Should this live in |
Sure, but not critical @johnzl-777. |
Co-authored-by: John Long <[email protected]>
I double-checked that these are the correct gates. I made sure that each one results in first an (optional) Z rotation then an (optional) X or Y rotation.