Skip to content

feat: copy submit run arguments from recent run #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxy-shpfy merged 1 commit into from
Jan 15, 2026
Merged

feat: copy submit run arguments from recent run #1622

maxy-shpfy merged 1 commit into from
Jan 15, 2026
+216 −29

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Jan 13, 2026 •
edited
Loading

Description

Closes https://github.com/Shopify/oasis-frontend/issues/420

Added a "Copy from recent run" feature to the Submit Task Arguments Dialog, allowing users to reuse arguments from previous pipeline runs. This enhances the workflow by making it easier to replicate successful runs without manually re-entering parameters.

The implementation includes:

  • A new popover component that displays recent pipeline runs
  • Functionality to fetch and apply arguments from selected runs
  • Enhanced PipelineRunsList component with new props for better customization
  • Added onClick handler to RunOverview component to support custom click actions

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Screen Recording 2026-01-12 at 6.09.34 PM.mov (uploaded via Graphite)

  1. Navigate to a pipeline with input arguments
  2. Click "Submit Run with Arguments"
  3. Use the "Copy from recent run" button
  4. Select a previous run to copy its arguments
  5. Verify the input fields are populated with values from the selected run

This was referenced Jan 13, 2026
Merged
Merged
Merged
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 13, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy mentioned this pull request Jan 13, 2026
Merged
4 tasks
@maxy-shpfy maxy-shpfy marked this pull request as ready for review January 13, 2026 02:10
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner January 13, 2026 02:10
@maxy-shpfy maxy-shpfy mentioned this pull request Jan 13, 2026
Merged
4 tasks
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 10479d0 to a5d0cd3 Compare January 13, 2026 02:48
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from b99e8dd to 94305c9 Compare January 13, 2026 17:51
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from a5d0cd3 to 6f6daa8 Compare January 13, 2026 17:51
@maxy-shpfy maxy-shpfy mentioned this pull request Jan 13, 2026
Merged
4 tasks
camielvs
camielvs reviewed Jan 13, 2026
View reviewed changes
camielvs
camielvs reviewed Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth giving a notification or message when using arguments from a recent run if the inputs have changed on that pipeline?

@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 6f6daa8 to 685d821 Compare January 14, 2026 00:39
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from 94305c9 to 3414ae9 Compare January 14, 2026 00:39
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 14, 2026

@camielvs I applied highlight animation to changed values

@maxy-shpfy maxy-shpfy requested a review from camielvs January 14, 2026 00:55
@camielvs Graphite App
Copy link
Collaborator

camielvs commented Jan 14, 2026

nice

camielvs
camielvs reviewed Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@camielvs camielvs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two observations on the new highlight feature:

Left side of highlighting is cut off

image.png

And the highlight seems to appear even if I select a different run and the value is the still same

highlightedwithnochange.mov (uploaded via Graphite)

@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 685d821 to 6da60a1 Compare January 15, 2026 00:49
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 15, 2026

@camielvs I fixed visuals, and the bug when highlighting was appearing on re-opening the dialog. But I can't reproduce behavior where the same value is highlighted.

image.png

@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 6da60a1 to 73d1e7e Compare January 15, 2026 01:10
@maxy-shpfy maxy-shpfy requested a review from camielvs January 15, 2026 01:12
camielvs
camielvs approved these changes Jan 15, 2026
View reviewed changes
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed

@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from 3414ae9 to 8040212 Compare January 15, 2026 02:52
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 73d1e7e to fc1f770 Compare January 15, 2026 02:53
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from 8040212 to 422cc17 Compare January 15, 2026 08:15
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from fc1f770 to 54cfa8a Compare January 15, 2026 08:16
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch 2 times, most recently from a045528 to 314711f Compare January 15, 2026 08:19
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 54cfa8a to dc61db2 Compare January 15, 2026 08:19
@maxy-shpfy maxy-shpfy changed the base branch from 01-12-feat_submit_run_with_arguments to graphite-base/1622 January 15, 2026 08:22
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from dc61db2 to 003c33e Compare January 15, 2026 08:22
@graphite-app graphite-app bot changed the base branch from graphite-base/1622 to master January 15, 2026 08:22
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 003c33e to c97f936 Compare January 15, 2026 08:22
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 15, 2026 •
edited
Loading

Merge activity

  • Jan 15, 8:30 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 15, 8:30 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit da4f741 into master Jan 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camielvs camielvs camielvs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxy-shpfy @camielvs