Skip to content

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Jan 13, 2026

Description

Closes https://github.com/Shopify/oasis-frontend/issues/411

Updated behavior for "Clone Pipeline" button on the Pipeline Run Details page. This button clones a pipeline while preserving the arguments used in the original run, allowing users to quickly create a new pipeline with the same parameter values.

Following decisions made in sync meeting:

Where to hold arguments
In short-term it’s OK to store them anywhere as long as this implementation detail does not leak into submitted and exported pipelines.
Currently, UI code stores pipeline-level arguments inside pipeline-level inputs (InputSpec.value).

To keep behavior consistent former "Clone Pipeline" button should be removed - https://app.graphite.com/github/pr/TangleML/tangle-ui/1628/fix-remove-redundant-clone-pipeline-from-the-top-menu

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Screen Recording 2026-01-13 at 10.39.45 PM.mov (uploaded via Graphite)

  1. Navigate to a completed pipeline run
  2. Verify that both clone buttons are visible:
    • The original "Clone Pipeline" button
    • The new "Clone Pipeline with Arguments" button
  3. Click the "Clone Pipeline with Arguments" button
  4. Verify that the new pipeline opens in the editor with all input parameters pre-filled with values from the original run argumentsFol

Copy link
Collaborator Author

@maxy-shpfy maxy-shpfy marked this pull request as ready for review January 13, 2026 19:30
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner January 13, 2026 19:30
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from aee0385 to 22badcd Compare January 13, 2026 19:36
@maxy-shpfy maxy-shpfy force-pushed the 01-13-feat_clone_pipeline_from_run_with_arguments branch from e7673d3 to 4885e24 Compare January 13, 2026 19:36
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking out loud: does it need to be a separate button?

The clone button could clone the original pipeline and then separately clone the overrides/run arguments. Then you get the pipeline (with its original input nodes & defaults) with the configured arguments as it was at time of submission. The user can then choose, via the dialog, to reconfigure and submit with those arguments or submit the original as per existing flow for a new pipeline

@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from 22badcd to bf9c8e9 Compare January 14, 2026 00:39
@maxy-shpfy maxy-shpfy force-pushed the 01-13-feat_clone_pipeline_from_run_with_arguments branch from 4885e24 to 3fc27d2 Compare January 14, 2026 00:39
@maxy-shpfy maxy-shpfy marked this pull request as draft January 14, 2026 01:00
@maxy-shpfy maxy-shpfy force-pushed the 01-13-feat_clone_pipeline_from_run_with_arguments branch from 3fc27d2 to 9bb8a53 Compare January 14, 2026 06:38
Copy link
Collaborator Author

@camielvs I removed additional button and modified the behavior of existing "Clone pipeline" button

@maxy-shpfy maxy-shpfy marked this pull request as ready for review January 14, 2026 06:59
@maxy-shpfy maxy-shpfy requested a review from camielvs January 14, 2026 07:02
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants