forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 89
[GEN][ZH] Fix Memory Manager initialization issues #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xezon
merged 3 commits into
TheSuperHackers:main
from
xezon:xezon/fix-memory-initialization-issues-2
Jul 14, 2025
Merged
[GEN][ZH] Fix Memory Manager initialization issues #1275
xezon
merged 3 commits into
TheSuperHackers:main
from
xezon:xezon/fix-memory-initialization-issues-2
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
helmutbuhler
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
xezon
commented
Jul 14, 2025
733e293
to
bc3b27c
Compare
Replicated to Generals with conflicts
|
xezon
added a commit
that referenced
this pull request
Jul 15, 2025
This was referenced Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fix
Is fixing something, but is not user facing
Memory
Is memory related
Minor
Severity: Minor < Major < Critical < Blocker
ThisProject
The issue was introduced by this project, or this task is specific to this project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes Memory Manager initialization issues and is an alternative implementation to #1236.
The Memory Pools are now created before the debug logging is initialized. To not lose asserts during Memory Manager initialization, the DEBUG_CRASH can now create message boxes without logging.
TODO