bugfix(selection): Prevent exploits from grouping structures and units #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roossienb
changed the title
roossienb
force-pushed
the
fix-scud-bug-through-add-group
branch
from
309d7b8 to
c5297f7
Compare
roossienb
changed the title
roossienb
force-pushed
the
fix-scud-bug-through-add-group
branch
from
c5297f7 to
987fcc2
Compare
xezon
reviewed
Jul 23, 2025
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
roossienb
commented
Jul 24, 2025
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
roossienb
force-pushed
the
fix-scud-bug-through-add-group
branch
from
987fcc2 to
58a39bd
Compare
|
Removed the dependency and have taken the logic out of the for-loop. |
roossienb
changed the title
Caball009
changed the title
xezon
changed the title
34 tasks
Mauller
approved these changes
Aug 26, 2025
xezon
reviewed
Aug 29, 2025
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
…group to a unit selection
roossienb
force-pushed
the
fix-scud-bug-through-add-group
branch
from
58a39bd to
c3fd272
Compare
xezon
approved these changes
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While EA fixed the group force attack exploit ("scud bug") when one was trying to add a building to a group with units, it was still possible to do the reverse: Add the building to a group. Select a bunch of units and than add-select ('shift') the group to the current selection.
To remedy this, every object in the group needs to be checked for kindof building when getting added to an existing selection.