FIX: Removing dependencies on VRModule #2251
Conversation
| { | ||
| "name": "com.unity.modules.vr", | ||
| "expression": "1.0.0", | ||
| "define": "UNITY_INPUT_SYSTEM_ENABLE_VR" |
There was a problem hiding this comment.
should we also need to remove code that utilize UNITY_INPUT_SYSTEM_ENABLE_VR?
There was a problem hiding this comment.
There were no code paths left in the InputSystem or Engine repository that utilized the define UNITY_INPUT_SYSTEM_ENABLE_VR
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2251 +/- ##
========================================
Coverage 76.70% 76.71%
========================================
Files 465 465
Lines 87919 87911 -8
========================================
- Hits 67442 67440 -2
+ Misses 20477 20471 -6 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…System into vrmodule-deprecation
|
|
RogPodge
changed the title
| #pragma warning restore CS0618 | ||
| } | ||
| #endif | ||
| } |
There was a problem hiding this comment.
Nice. Can we remove the now empty Awake and OnDestroy as well? Thanks
| - Fixed an issue in `Keyboard` where the sub-script operator would return a `null` key control for the deprecated key `Key.IMESelected`. Now, an aliased `KeyControl`mapping to the IMESelected bit is returned for compability reasons. It is still strongly advised to not rely on this key since `IMESelected` bit isn't strictly a key and will be removed from the `Key` enumeration type in a future major revision. [ISXB-1541](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1541). | ||
| - Fixed InputControl picker not updating correctly when the Input Actions Window was dirty. [ISXB-1221](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1221) | ||
| - Fixed formatting issues on processor documentation page | ||
| - Fixed an issue where a warning would be appear due to code referencing the obsolete com.unity.modules.vr package. |
There was a problem hiding this comment.
There is a typo in the message. However, the warning part should have already been covered by Fixed the compilation warnings when used with Unity 6.4 (ISX-2349). just a few lines above in the changelog (as part of that change we also added a suppression message that made this warning go away). Provided that, maybe we should put this note in another section and say something like Changed: Input System no longer depends on the obsolete com.unity.modules.vr package ?
| "com.unity.modules.unitywebrequestwww": "1.0.0", | ||
| "com.unity.modules.vehicles": "1.0.0", | ||
| "com.unity.modules.video": "1.0.0", | ||
| "com.unity.modules.vr": "1.0.0", |
There was a problem hiding this comment.
Currently we have to support all Unity versions down to 2021.3 xLTS. Is this change aligned with that? Just asking to make sure. CC @ekcoh for viz.
Description
The VR Module is obsolete and slated to be removed in a future version of Unity: https://docs.unity3d.com/6000.3/Documentation/ScriptReference/UnityEngine.VRModule.html
This PR removes the dependency of the Input System Package from the VR Module. There is one functional change to the PR, where the AutoXRCameraTracking is disabled during
AwakeandOnDestroy. This function only works when using the Legacy XR Framework, and does nothing when using the modern XR architecture.Testing status & QA
N/A
Overall Product Risks
Comments to reviewers
Removal of the dependency on the VR Module will help make the full removal of the VR Module easier in the future.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: