[SJTC] Make scaling interface optional #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2024
added 2 commits
October 14, 2024 16:55
This way, the controller can be used on systems, where no scaling interface is available (e.g. GZ). The upstream version in ros2_controllers will have the same behavior.
VinDp
force-pushed
the
sjtc_without_scaling
branch
from
fd546b5 to
b54ca5e
Compare
VinDp
approved these changes
Oct 14, 2024
Contributor
VinDp
left a comment
VinDp
left a comment
There was a problem hiding this comment.
Looks good to me and it works as expected.
Contributor
Author
|
@Mergifyio backport iron |
✅ Backports have been created
|
Contributor
Author
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* [SJTC] Make scaling interface optional This way, the controller can be used on systems, where no scaling interface is available (e.g. GZ). The upstream version in ros2_controllers will have the same behavior. * Move logging to function that's only called once (cherry picked from commit 39ff78f)
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* [SJTC] Make scaling interface optional This way, the controller can be used on systems, where no scaling interface is available (e.g. GZ). The upstream version in ros2_controllers will have the same behavior. * Move logging to function that's only called once (cherry picked from commit 39ff78f)
This was referenced Oct 29, 2024
fmauch
pushed a commit
that referenced
this pull request
Oct 30, 2024
fmauch
pushed a commit
that referenced
this pull request
Oct 30, 2024
URJala
pushed a commit
to URJala/Universal_Robots_ROS2_Driver
that referenced
this pull request
Dec 20, 2024
* [SJTC] Make scaling interface optional This way, the controller can be used on systems, where no scaling interface is available (e.g. GZ). The upstream version in ros2_controllers will have the same behavior. * Move logging to function that's only called once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the controller can be used on systems, where no scaling interface is available (e.g. GZ). The upstream version in ros2_controllers will have the same behavior.
This is a part of fixing UniversalRobots/Universal_Robots_ROS2_GZ_Simulation#57