Use modern CMake to link against yaml-cpp #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
========================================
+ Coverage 3.59% 5.66% +2.07%
========================================
Files 13 31 +18
Lines 947 3072 +2125
Branches 152 375 +223
========================================
+ Hits 34 174 +140
- Misses 843 2896 +2053
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
urfeex
force-pushed
the
update_yaml_cpp_linkage
branch
from
72627e1 to
0376031
Compare
urrsk
approved these changes
Mar 18, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
* Use modern CMake to link against yaml-cpp * Remove direct yaml-cpp include (cherry picked from commit 843e500)
urfeex
pushed a commit
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we link against yaml-cpp seems to be a leftover from times where it didn't support modern CMake.
Fixes #1294