Support PolyScopeX robots #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urfeex
force-pushed
the
support_polyscope_x
branch
from
b53e894 to
674407c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1318 +/- ##
========================================
+ Coverage 3.59% 5.58% +1.99%
========================================
Files 13 31 +18
Lines 947 3117 +2170
Branches 152 377 +225
========================================
+ Hits 34 174 +140
- Misses 843 2941 +2098
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Before trying to establish a connection to the dashboard server, check the version of the connected robot. If it is a PolyScopeX robot, shutdown the dashboard client.
Otherwise it will go out of scope afterwards and it will not be usable.
urfeex
force-pushed
the
support_polyscope_x
branch
from
5201c69 to
d9d6922
Compare
urmahp
requested changes
Apr 3, 2025
Co-authored-by: Mads Holm Peters <[email protected]>
urmahp
approved these changes
Apr 4, 2025
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
* Shutdown dashboard client when connected to PolyScopeX robot Before trying to establish a connection to the dashboard server, check the version of the connected robot. If it is a PolyScopeX robot, shutdown the dashboard client. * Make robot_state_helper use primary_client whenever possible (cherry picked from commit 5162bf4) # Conflicts: # ur_robot_driver/src/robot_state_helper.cpp
urfeex
added a commit
that referenced
this pull request
Apr 7, 2025
* Shutdown dashboard client when connected to PolyScopeX robot Before trying to establish a connection to the dashboard server, check the version of the connected robot. If it is a PolyScopeX robot, shutdown the dashboard client. * Make robot_state_helper use primary_client whenever possible
urfeex
pushed a commit
that referenced
this pull request
Apr 7, 2025
* Shutdown dashboard client when connected to PolyScopeX robot Before trying to establish a connection to the dashboard server, check the version of the connected robot. If it is a PolyScopeX robot, shutdown the dashboard client. * Make robot_state_helper use primary_client whenever possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PolyScopeX robots don't have a dashboard server, we'll have to make sure to
a) not start the dashboard client when interacting with a PolyScopeX robot
b) replace the robot_state_helper's functions to the dashboard server with primary_client API calls.
This requires UniversalRobots/Universal_Robots_Client_Library#296 to work.