fix: Study by card state or tag dropdown menu is prone to overflow#18954
Conversation
There was a problem hiding this comment.
Thanks!!!
There was a ~16dp bottom margin which was removed by this change, it would look better if this were retained.
Could you also provide a before/after image of the selected item (when the spinner isn't open), as you've also modified how this is displayed.
I suspect the selected item should be truncated, but implementer's choice here.
Thank you for pointing it out. I haven't notice the change how the selected item is shown. I'd also prefer the truncated single-line style for the selected item.
|
f98b5ea to
1ab54ba
Compare
1ab54ba to
29397a1
Compare
`minHeight` is no longer enforced, so use `paddingVertical` if the height is over `minHeight` 14dp: by visual inspection, likely only correct for default text sizes Fixes: 18953 Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
29397a1 to
5c800c9
Compare
|
Hi there @snowtimeglass! This is the OpenCollective Notice for PRs merged from 2025-07-01 through 2025-07-31 If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding. Thanks! |










Purpose / Description
Some labels in

Study by card state or tagdropdown menu labels are relatively long, so they are prone to overflow on a single line.This PR aims to resolve the issue.
Fixes
Study by card state or tagdropdown menu is prone to overflow #18953Approach
Use the existing
multiline_spinner_item.xmlinstead ofsimple_spinner_itemfor layoutHow Has This Been Tested?
Checked on a physical device (Android 11)
Checklist