-
Notifications
You must be signed in to change notification settings - Fork 69
Add Arrow C Data Interface and nanoarrow dependency #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have managed to add
There are some other minor issues:
These are not blocking issues at the moment. I need more time to get familiar with its API and best practice. Just want to report what I have found so far. @JohanMabille @Alex-PLACET @pitrou |
24e84be to
cbf7d93
Compare
|
Hi there, Thanks for the test and report! We got similar issues when trying to build and use sparrow in WASM and we are pushing fixes for that (more specifically, the target_compile_definitions that are missing). I'll take the opportunity to fix the other issues you faced, we will release a new version right after. |
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably in the end we're only going to want one of the two libraries, right? It seems weird to potentially link up to 4 separate Arrow implementations in one project...
|
@lidavidm Yes, this is for the nanoarrow and sparrow comparison and finally one of them will be only used internally by the Let me fix the CI first. Then I think we need reach a consensus to choose one. |
|
IMO, it's going to be hard/pointless to choose one until we actually write code that needs it. I hope we can get the ball rolling sooner rather than later on actual implementation/binding work |
|
Agreed. The point of this PR is to demonstrate that we can use the Arrow C data interface as the main API for file reader and writer and internally we can process the data with the help of nanoarrow/sparrow. This is an independent work. In the meanwhile, I'll try to figure out the minimal set of interfaces that we need and create a PR for PoC later this week or next week. |
I have run into an error: https://github.com/apache/iceberg-cpp/actions/runs/13943870527/job/39026477819. It seems that I can get rid of it by removing the I will polish this PR to depend on only |
|
Sounds good to me |
|
Agreed, nanoarrow sounds good to me. |
zhjwpku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this.
|
Thank you, @Fokko! |
Closes #33