Skip to content

try can use automatic resource management 1/2 #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

try can use automatic resource management 1/2 #2401

wants to merge 1 commit into from

Conversation

@Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented May 28, 2025 •
edited
Loading

@Pankraz76 Pankraz76 mentioned this pull request May 28, 2025
Closed
@Pankraz76 Pankraz76 marked this pull request as ready for review May 28, 2025 13:50
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented May 28, 2025

again NPE:

Error:  Errors: 
Error:    MavenIT0008SimplePluginTest.testit0008:45 » NullPointer Cannot invoke "java.io.File.exists()" because "dir" is null
Error:    MavenIT0010DependencyClosureResolutionTest.testit0010:47 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0011DefaultVersionByDependencyManagementTest.testit0011:44 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0018DependencyManagementTest.testit0018:42 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0021PomProfileTest.testit0021:42 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0030DepPomDepMgmtInheritanceTest.testit0030:40 » NullPointer Cannot invoke "java.io.File.exists()" because "dir" is null
Error:    MavenIT0041ArtifactTypeFromPluginExtensionTest.testit0041:47 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0085TransitiveSystemScopeTest.testit0085:48 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0087PluginRealmWithProjectLevelDepsTest.testit0087:53 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0142DirectDependencyScopesTest.testit0142:56 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitCompileScope:53->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitProvidedScope:113->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitRuntimeScope:162->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitTestScope:211->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0146InstallerSnapshotNaming.testitNonTimestampedNameWithInstalledSNAPSHOT:102 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0146InstallerSnapshotNaming.testitRemoteDownloadTimestampedName:86 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenITmng0377PluginLookupFromPrefixTest.testitMNG377:49 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenITmng0461TolerateMissingDependencyPomTest.testit:51 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
[INFO] 
Error:  Tests run: 978, Failures: 0, Errors: 18, Skipped: 49
[INFO]

@Pankraz76
Copy link
Contributor Author

Pankraz76 commented May 29, 2025

interesting, will give SOC to isolate error.

@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 6cd950e to 24bf3f7 Compare May 29, 2025 10:06
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 24bf3f7 to 64e3eeb Compare May 29, 2025 13:25
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 66de8c0 to 188917a Compare May 29, 2025 13:32
Pankraz76
Pankraz76 commented May 29, 2025
View reviewed changes
Copy link
Contributor Author

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dedicate in PR to fix API.

elharo
elharo requested changes May 29, 2025
View reviewed changes
elharo
elharo requested changes May 29, 2025
View reviewed changes
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 6f9277a to 2868991 Compare May 29, 2025 18:54
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch 2 times, most recently from bc2a256 to 012e5de Compare May 29, 2025 19:23
Pankraz76
Pankraz76 commented May 29, 2025
View reviewed changes
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented May 29, 2025

build success assuming new flaky test failing on main as well:

MavenExecutorTestSupport.version:125

image

@Pankraz76 Pankraz76 requested a review from elharo May 29, 2025 19:27
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch 2 times, most recently from 5bc68d5 to b6ee7d7 Compare May 29, 2025 19:31
Pankraz76
Pankraz76 commented May 29, 2025
View reviewed changes
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from feabadc to 1e8099b Compare May 29, 2025 19:36
elharo
elharo requested changes May 29, 2025
View reviewed changes
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 1e8099b to a7b5d39 Compare May 29, 2025 20:00
@Pankraz76 Pankraz76 requested a review from elharo May 29, 2025 20:01
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from a7b5d39 to fae37ed Compare May 29, 2025 20:09
@Pankraz76 Pankraz76 requested a review from elharo May 29, 2025 20:11
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented May 29, 2025

lets get this.

@Pankraz76
Copy link
Contributor Author

Pankraz76 commented May 29, 2025

items:

Error:  Failures: 
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was: <unknown>
[INFO] 
Error:  Tests run: 54, Failures: 4, Errors: 0, Skipped: 5

@Pankraz76
Copy link
Contributor Author

Pankraz76 commented May 29, 2025 •
edited
Loading

Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:

this one failing on main for me as well.

image

@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from fae37ed to 3d0bb8b Compare May 30, 2025 15:06
@Pankraz76 Pankraz76 mentioned this pull request May 31, 2025
Closed
9 tasks
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jun 1, 2025 •
edited
Loading

item:
[INFO] Results:
[INFO]
Error: Failures:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:
[INFO]
Error: Tests run: 54, Failures: 4, Errors: 0, Skipped: 5
[INFO]

image

@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jun 2, 2025

Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:

this seems flaky. Locally everything´s fine.

@Pankraz76 Pankraz76 changed the title try can use automatic resource management try can use automatic resource management 1/2 Jun 2, 2025
@Pankraz76 Pankraz76 mentioned this pull request Jun 2, 2025
Merged
@Pankraz76 Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 3d0bb8b to cc3b23b Compare June 2, 2025 07:07
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jun 2, 2025

lets see if separation is enough to isolate issue.

@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jun 2, 2025

lets make this 1o1, its persistent issue:

Error: Failures:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:
[INFO]
Error: Tests run: 5

@Pankraz76 Pankraz76 marked this pull request as draft June 2, 2025 11:38
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jun 2, 2025 •
edited
Loading

need to give this dedication

@Pankraz76 Pankraz76 closed this Jun 2, 2025
This was referenced Jun 5, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elharo elharo elharo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @elharo