refactor(ekf_localizer): move header files of ekf_localizer#726
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
+ Coverage 50.35% 50.46% +0.10%
==========================================
Files 358 362 +4
Lines 22780 22839 +59
Branches 10120 10150 +30
==========================================
+ Hits 11472 11525 +53
- Misses 10203 10209 +6
Partials 1105 1105
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cbb3e3f to
0ff08b6
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
Still in consideration. |
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
0ff08b6 to
1daa0c7
Compare
There was a problem hiding this comment.
@Motsu-san Perhaps it might be better to use include not internal as the Autoware official documentation.
@sasakisasaki Thank you for your review! I'm not sure why I named as it. I'll fix it. |
81a72bf to
ba90fef
Compare
sasakisasaki
left a comment
There was a problem hiding this comment.
Reviewed. Also as the CI build/tests which involves whole Autoware succeeded, I agree with merging this PR. Thank you so much for your contribution!
interimadd
left a comment
There was a problem hiding this comment.
I've confirmed that all changes are for the migration of header files.
LGTM!
Description
Headers that are not publicly exposed should be moved to src/.
This makes it clear what constitutes the public API.
Related links
Parent Issue:
How was this PR tested?
(ADDED by @sasakisasaki ) Required CI passed as this
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.