Skip to content

refactor(ekf_localizer): move header files of ekf_localizer#726

Merged
sasakisasaki merged 11 commits intoautowarefoundation:mainfrom
Motsu-san:refactor/move_header_file
Mar 3, 2026
Merged

refactor(ekf_localizer): move header files of ekf_localizer#726
sasakisasaki merged 11 commits intoautowarefoundation:mainfrom
Motsu-san:refactor/move_header_file

Conversation

@Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Nov 26, 2025

Description

Headers that are not publicly exposed should be moved to src/.
This makes it clear what constitutes the public API.

Related links

Parent Issue:

  • Link

How was this PR tested?

(ADDED by @sasakisasaki ) Required CI passed as this

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Motsu-san Motsu-san changed the title refactor(ekf_localizer):move header file of ekf_localizer refactor(ekf_localizer): move header file of ekf_localizer Nov 26, 2025
@Motsu-san Motsu-san added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Nov 26, 2025
@Motsu-san Motsu-san changed the title refactor(ekf_localizer): move header file of ekf_localizer refactor(ekf_localizer): move header files of ekf_localizer Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.46%. Comparing base (d091381) to head (5570e6c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   50.35%   50.46%   +0.10%     
==========================================
  Files         358      362       +4     
  Lines       22780    22839      +59     
  Branches    10120    10150      +30     
==========================================
+ Hits        11472    11525      +53     
- Misses      10203    10209       +6     
  Partials     1105     1105              
Flag Coverage Δ *Carryforward flag
daily-humble 50.69% <ø> (-0.04%) ⬇️ Carriedforward from e232aec
daily-jazzy 50.18% <ø> (-0.04%) ⬇️ Carriedforward from e232aec
differential-humble 55.38% <100.00%> (?)
total 50.38% <ø> (-0.01%) ⬇️ Carriedforward from e232aec
total-humble 50.72% <ø> (-0.01%) ⬇️ Carriedforward from e232aec
total-jazzy 50.21% <ø> (+<0.01%) ⬆️ Carriedforward from e232aec

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stale
Copy link

stale bot commented Jan 25, 2026

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 25, 2026
@Motsu-san
Copy link
Contributor Author

Still in consideration.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Feb 16, 2026
Motsu-san and others added 6 commits February 17, 2026 14:50
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
@Motsu-san Motsu-san force-pushed the refactor/move_header_file branch from 0ff08b6 to 1daa0c7 Compare February 17, 2026 05:52
@Motsu-san Motsu-san marked this pull request as ready for review February 17, 2026 06:05
Copy link
Contributor

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Motsu-san Perhaps it might be better to use include not internal as the Autoware official documentation.

@Motsu-san
Copy link
Contributor Author

Motsu-san commented Feb 25, 2026

@Motsu-san Perhaps it might be better to use include not internal as the Autoware official documentation.

@sasakisasaki Thank you for your review! I'm not sure why I named as it. I'll fix it.

Motsu-san and others added 2 commits February 25, 2026 17:50
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
@Motsu-san Motsu-san force-pushed the refactor/move_header_file branch from 81a72bf to ba90fef Compare February 25, 2026 08:50
Copy link
Contributor

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Also as the CI build/tests which involves whole Autoware succeeded, I agree with merging this PR. Thank you so much for your contribution!

@sasakisasaki sasakisasaki requested review from a team and interimadd March 3, 2026 09:59
Copy link
Contributor

@interimadd interimadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that all changes are for the migration of header files.
LGTM!

@sasakisasaki sasakisasaki enabled auto-merge (squash) March 3, 2026 11:34
@sasakisasaki sasakisasaki merged commit f20e40b into autowarefoundation:main Mar 3, 2026
39 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants