Skip to content

Convert MeshPipelineViewLayouts , MeshPipeline and RenderDebugOverlayPipeline to RenderStartup system#22443

Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Zeophlite:render-startup-mesh-pipeline
Feb 24, 2026
Merged

Convert MeshPipelineViewLayouts , MeshPipeline and RenderDebugOverlayPipeline to RenderStartup system#22443
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Zeophlite:render-startup-mesh-pipeline

Conversation

@Zeophlite
Copy link
Contributor

@Zeophlite Zeophlite commented Jan 9, 2026

Objective

  • Convert MeshPipelineViewLayouts , MeshPipeline and RenderDebugOverlayPipeline to RenderStartup system

Solution

  • Do the thing

Testing

  • Ran animated_mesh example

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Jan 9, 2026
@alice-i-cecile alice-i-cecile added the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Jan 9, 2026
@Zeophlite Zeophlite changed the title Convert MeshPipelineViewLayouts and MeshPipeline to RenderStartup system Convert MeshPipelineViewLayouts and MeshPipeline to RenderStartup system Jan 9, 2026
@Zeophlite Zeophlite requested a review from atlv24 January 9, 2026 03:06
@Zeophlite Zeophlite marked this pull request as ready for review January 9, 2026 03:06
@Zeophlite Zeophlite added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jan 9, 2026
@cart cart added this to Rendering Feb 12, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Feb 12, 2026
@cart cart removed this from Rendering Feb 12, 2026
@Zeophlite Zeophlite changed the title Convert MeshPipelineViewLayouts and MeshPipeline to RenderStartup system Convert MeshPipelineViewLayouts , MeshPipeline and RenderDebugOverlayPipeline to RenderStartup system Feb 21, 2026
@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 21, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Feb 21, 2026
@alice-i-cecile
Copy link
Member

@Zeophlite, can you resolve merge conflicts quick?

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 24, 2026
Merged via the queue into bevyengine:main with commit 329332a Feb 24, 2026
38 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Feb 24, 2026
@mockersf
Copy link
Member

Some changes were missed, done in #23147
Also added a migration guide as this is a breaking change

@mockersf mockersf added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Feb 25, 2026
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2026
# Objective

- #22443 broke wireframe and some examples

## Solution

- Fix them by having the systems run after `MeshPipelineSet`
- Also add a migration guide

## Testing

- run the examples modified or anything using wireframe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done
Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants