Member search

[jonodrew]

This adds a controller and little view for doing member searches. Full implementation of this pattern will require calling services to add a callback param to the request to MemberSearch, which it will then GET once the Member(s) have been found.

If only one member is found from the search, I've chosen to assume that it's correct and we skip straight to redirecting to the calling service. That might be a faulty assumption.

I'm going to clear up the commit history, but it'll give you an early sense of how this is working. Screenshots!

[jonodrew]

@matyikriszta do you mind giving me a sense-check on this? Does it look like it's going in the right direction?

[olleolleolle]

Just wanted to share some Rails thoughts.

EDIT: I don't want to block you, perhaps we can pair sometime, to brain-sync on this!

[davidmillen50]

what happens if you try to search with no search terms?

[jonodrew]

what happens if you try to search with no search terms?

That was a good question. I've added a check against it returning the entire table!

[jonodrew]

Tests are not failing, coveralls is 😞

[jonodrew]

@olleolleolle @matyikriszta @KimberleyCook - I'd like to integrate this code into the codebase before I start working on calling it from elsewhere. I suspect the approach is going to be a little complex, and I don't want to make a massive change all at once.

Tests are passing locally but not here - there's more flakiness around I think.

Going forward, I'm thinking about how this can be incorporated into other calling services. I'm considering moving the logic in Admin::InvitationsController#update_attendance into a method on the Invitation model, so I can access it from within any Controller. Let me know what you think.