Update API & toolchain-common (to check removal of che config) #1209
Conversation
Signed-off-by: Feny Mehta <[email protected]>
WalkthroughUpdates Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: ci-check-gomod
go.mod
[error] 1-1: Disallowed go.mod replacement detected by CI script: the above replacement(s) are not allowed in go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: GolangCI Lint
- GitHub Check: Test with Coverage
- GitHub Check: Build & push operator bundles for e2e tests
Signed-off-by: Feny Mehta <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
go.mod (1)
41-41: Consolidate go-bindata imports to/v3
- Upstream
github.com/codeready-toolchain/apiis pulling ingithub.com/go-bindata/go-bindata v3.1.2+incompatible. Bump it to a release that uses/v3to eliminate the+incompatiblevariant.- If you can’t update that dependency yet, keep both requires but add a comment in
go.modexplaining the dual paths and always prefer/v3in new code.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & push operator bundles for e2e tests
🔇 Additional comments (1)
go.mod (1)
154-156: Confirm CI/tooling supports the toolchain directive and Go 1.23.x.
go 1.23.0withtoolchain go1.23.12requires builders using Go ≥1.21 with toolchains enabled. Older environments will fail to fetch the toolchain.Please verify the CI image and local dev env honor the toolchain directive (e.g., GOTOOLCHAIN=auto) and have network egress for toolchain downloads. If not, pin CI to Go 1.23.x directly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
=======================================
Coverage 71.00% 71.00%
=======================================
Files 83 83
Lines 8069 8069
=======================================
Hits 5729 5729
Misses 2131 2131
Partials 209 209 🚀 New features to boost your workflow:
|
2 participants
The verify dependencies test case was failing for the PR to remove
cherelated code from api and toolchain-common .This PR is updating the go dependencies for api and toolchain-common to make sure we are not breaking anything before we merge the api and tc PRs
Related PRs:
Similar PRs:
Summary by CodeRabbit