Skip to content

Conversation

@fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Oct 6, 2025

The verify dependencies test case was failing for the PR to remove che related code from api and toolchain-common .
This PR is updating the go dependencies for api and toolchain-common to make sure we are not breaking anything before we merge the api and tc PRs

Related PRs:

Similar PRs:

Summary by CodeRabbit

  • Chores
    • Updated underlying dependencies to newer maintained versions.
    • No changes to features, UI, or workflows; behavior remains unchanged.
    • Improves build consistency and long-term maintenance.
    • No user action or configuration changes required.

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Oct 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 6, 2025

Walkthrough

Updated go.mod to bump two dependency versions: github.com/codeready-toolchain/api and github.com/codeready-toolchain/toolchain-common. No other files or exported API declarations were changed.

Changes

Cohort / File(s) Summary
Dependency version bumps
go.mod
Updated required versions: github.com/codeready-toolchain/apiv0.0.0-20251008084914-06282b83d4cd and github.com/codeready-toolchain/toolchain-commonv0.0.0-20251006132314-2591ebe0bdb1. No other require blocks modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • mfrancisc
  • rajivnathan
  • rsoaresd

Poem

I hop through lines of versioned greens,
Two deps nudged to fresher scenes,
go.mod trimmed and neatly done,
A rabbit naps — the build will run. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly identifies that the pull request updates the API and toolchain-common modules to validate removal of the che configuration, which directly reflects the changeset of bumping those dependencies without introducing extraneous information.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae700c4 and 4c6847f.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Unit Tests
  • GitHub Check: GolangCI Lint
  • GitHub Check: Build & push Developer Sandbox UI image for UI e2e tests
  • GitHub Check: Build & push operator bundles for e2e tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 273dd90 and ae700c4.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build & push Developer Sandbox UI image for UI e2e tests
  • GitHub Check: Build & push operator bundles for e2e tests

Signed-off-by: Feny Mehta <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Feny Mehta <[email protected]>
@sonarqubecloud
Copy link

@fbm3307 fbm3307 merged commit 53e9630 into codeready-toolchain:master Oct 16, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants