Update API & toolchain-common (to check removal of che config) #705
Conversation
Signed-off-by: Feny Mehta <[email protected]>
WalkthroughUpdated Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: GolangCI Lint
- GitHub Check: Test with Coverage
- GitHub Check: Build & push operator bundles for e2e tests
go.mod
Outdated
| replace github.com/codeready-toolchain/api => github.com/fbm3307/toolchainapi v0.0.0-20250924125641-c3fceab9da63 | ||
|
|
||
| replace github.com/codeready-toolchain/toolchain-common => github.com/fbm3307/toolchain-common v0.0.0-20250923073415-a1ecb04daf74 |
There was a problem hiding this comment.
Commit the go.sum updates for these replacements.
The new replace targets introduce fresh module paths, but there’s no matching go.sum update in this PR. On a clean checkout the Go toolchain will rewrite go.sum to add the checksums (and possibly drop the old ones), leaving the tree dirty and breaking any CI step that enforces a clean workspace. Please rerun go mod tidy (or go mod download for the specific versions) and commit the resulting go.sum changes.
🤖 Prompt for AI Agents
In go.mod around lines 132 to 134, you added replace directives pointing to new
module versions but did not update go.sum; run `go mod tidy` (or `go mod
download github.com/fbm3307/[email protected]
github.com/fbm3307/[email protected]`) to
update go.sum and then commit the updated go.sum so the workspace remains clean
for CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 80.81% 80.81%
=======================================
Files 48 48
Lines 4478 4478
=======================================
Hits 3619 3619
Misses 698 698
Partials 161 161 🚀 New features to boost your workflow:
|
Signed-off-by: Feny Mehta <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Feny Mehta <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: GolangCI Lint
- GitHub Check: Build & push operator bundles for e2e tests
- GitHub Check: Test with Coverage
| github.com/codeready-toolchain/api v0.0.0-20251008084914-06282b83d4cd | ||
| github.com/codeready-toolchain/toolchain-common v0.0.0-20251006132314-2591ebe0bdb1 |
There was a problem hiding this comment.
Commit the go.sum refresh for the bumped modules.
These new pseudo-versions need matching checksums in go.sum. On a clean checkout go build/go test will rewrite go.sum, leaving the workspace dirty and failing CI cleanliness gates. Please rerun go mod tidy (or go mod download github.com/codeready-toolchain/[email protected] github.com/codeready-toolchain/[email protected]) and commit the resulting go.sum changes.
🤖 Prompt for AI Agents
In go.mod around lines 4 to 5, the bumped pseudo-versions lack corresponding
checksums in go.sum; run `go mod tidy` (or `go mod download
github.com/codeready-toolchain/[email protected]
github.com/codeready-toolchain/[email protected]`)
to refresh go.sum and then commit the updated go.sum so CI cleanliness gates no
longer fail.
|
2 participants
The verify dependencies test case was failing for the PR to remove
cherelated code from api and toolchain-common .This PR is updating the go dependencies for api and toolchain-common to make sure we are not breaking anything before we merge the api and tc PRs
Related PRs:
Similar PRs:
Summary by CodeRabbit