-
Notifications
You must be signed in to change notification settings - Fork 1k
Support subscriptions by replying to ping message #6616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CrisBarreiro
wants to merge
5
commits into
cris/adsjs/support-messaging-responses
Choose a base branch
from
cris/adsjs/add-subscriptions
base: cris/adsjs/support-messaging-responses
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support subscriptions by replying to ping message #6616
CrisBarreiro
wants to merge
5
commits into
cris/adsjs/support-messaging-responses
from
cris/adsjs/add-subscriptions
+250
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
49789e6
to
b21ac79
Compare
a876d17
to
cf0b7c9
Compare
8b6def6
to
04a6002
Compare
4419a8a
to
f688897
Compare
04a6002
to
168009b
Compare
3 tasks
f688897
to
551fa17
Compare
4441402
to
02ad05a
Compare
551fa17
to
fd8bc1f
Compare
02ad05a
to
a5c2c09
Compare
fd8bc1f
to
59f0b6a
Compare
a92db0f
to
0aa6479
Compare
9a234fe
to
2a16166
Compare
37a86a6
to
8d30eb3
Compare
2a16166
to
c10bb68
Compare
512911d
to
6b8f7c6
Compare
8a684d1
to
377ea75
Compare
6b8f7c6
to
8104fea
Compare
377ea75
to
66684c8
Compare
40387e5
to
6bed82c
Compare
2ab4490
to
26a4ca4
Compare
b2a391f
to
daf105e
Compare
26a4ca4
to
97c6987
Compare
daf105e
to
8414617
Compare
97c6987
to
2c7ad20
Compare
8414617
to
2aab049
Compare
8c862b7
to
1fb4b2a
Compare
7060075
to
95ab626
Compare
1fb4b2a
to
983a564
Compare
467e1ca
to
e887080
Compare
983a564
to
7c51bf2
Compare
8ba6090
to
5e404c4
Compare
7c51bf2
to
9ced48c
Compare
bd84ff0
to
015c15d
Compare
9ced48c
to
2f89eea
Compare
015c15d
to
59077ce
Compare
2f89eea
to
3a8cf2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1205008441501016/task/1211092095433618?focus=true
Description
C-S-S sends us a ping message so we have a reference to a reply proxy that we store and use to send messages after a user action is initiated on the native side
Steps to test this PR
Pre-requisites
WebViewCompatBreakageContentScopeJsMessageHandler#process
andWebViewCompatWebCompatMessagingPlugin#postMessage
useNewWebCompatApis
under feature flag inventory (enabled by default)Desktop mode
Breakage reporting
getBreakageReportValues
is sent, and message with methodbreakageReportResult
is receivedDisable protections
top frame header - "1"
top frame JS API - true
frame JS API - true
top frame header - ...
top frame JS API - ...
frame JS API - ...
UI changes
n/a