Skip to content

chore(consume): remove consume hive command #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025

Conversation

richardgreg
Copy link
Contributor

🗒️ Description

  • Remove broken consume hive command and related code paths
  • Update help tests to exclude removed command

I went with sunsetting the cmd because users can already achieve the same result by running both commands separately:
uv run consume rlp --input ./fixtures
uv run consume engine --input ./fixtures

🔗 Related Issues or PRs

Fixes #1984

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@richardgreg richardgreg force-pushed the fix/remove-consume-hive-cmd branch from 721d9c5 to c541adf Compare August 7, 2025 21:30
@spencer-tb
Copy link
Contributor

I'm in favor of removing but I'd like to get @danceratopz opininion here. I personally never use it!

@danceratopz danceratopz self-requested a review August 11, 2025 21:34
@richardgreg richardgreg force-pushed the fix/remove-consume-hive-cmd branch 2 times, most recently from 37b8b1a to af735a9 Compare August 12, 2025 15:14
* Remove broken `consume hive` command and related code paths
* Update help tests to exclude removed command
@richardgreg richardgreg force-pushed the fix/remove-consume-hive-cmd branch from af735a9 to c5b4b6e Compare August 12, 2025 15:18
@richardgreg
Copy link
Contributor Author

No idea why everything is red. Investigating

@danceratopz
Copy link
Member

No idea why everything is red. Investigating

Looks like it was a glitch. Actions re-running now.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@danceratopz danceratopz changed the title chore(consume): remove non-functional hive command chore(consume): remove consume hive command Aug 14, 2025
@danceratopz danceratopz added type:chore Type: Chore scope:consume Scope: Consume command suite labels Aug 14, 2025
@danceratopz danceratopz merged commit bf67cb7 into ethereum:main Aug 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consume hive command is broken
3 participants