Fix MinGW build failure due to incorrect /STACK flag#3046
Open
amyssnippet wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix MinGW build failure due to incorrect /STACK flag#3046amyssnippet wants to merge 1 commit intogoogle-deepmind:mainfrom
amyssnippet wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
2 tasks
Author
|
@saran-t kindly review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3040.
The build was failing on MinGW because the linker was receiving the MSVC-style
/STACKflag, which is treated as a file path byld. this pr:-Wl,--stack,16777216when building with MinGW./STACKflag for MSVC.