Skip to content

Fix MinGW build failure due to incorrect /STACK flag #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amyssnippet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MinGW build failure due to incorrect /STACK flag #3046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions cmake/MujocoLinkOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,17 @@ include(CheckCSourceCompiles)
# Gets the appropriate linker options for building MuJoCo, based on features available on the
# linker.
function(get_mujoco_extra_link_options OUTPUT_VAR)
if(WIN32 AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
set(MINGW TRUE)
else()
set(MINGW FALSE)
endif()
if(MSVC)
set(EXTRA_LINK_OPTIONS /OPT:REF /OPT:ICF=5 /STACK:16777216)
set(EXTRA_LINK_OPTIONS /OPT:REF /OPT:ICF=5)
else()
set(EXTRA_LINK_OPTIONS)

if(WIN32)
set(EXTRA_LINK_OPTIONS ${EXTRA_LINK_OPTIONS} -Wl,/STACK:16777216)
set(CMAKE_REQUIRED_FLAGS "-fuse-ld=lld-link")
check_c_source_compiles("int main() {}" SUPPORTS_LLD)
if(SUPPORTS_LLD)
Expand Down Expand Up @@ -61,6 +65,12 @@ function(get_mujoco_extra_link_options OUTPUT_VAR)
endif()
endif()

if(MSVC)
list(APPEND EXTRA_LINK_OPTIONS /STACK:16777216)
elseif(MINGW)
list(APPEND EXTRA_LINK_OPTIONS -Wl,--stack,16777216)
endif()

set("${OUTPUT_VAR}"
${EXTRA_LINK_OPTIONS}
PARENT_SCOPE
Expand Down