Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
2 tasks
eholum
force-pushed
the
keyframe-validation-fixes
branch
from
aeae416 to
9486628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for #3071.
This modifies the
StoreKeyframesfunction in two ways. The first is to rebuild the tree prior to callingSaveDofOffsets, just so that it has an up-to-date set of joints over which to iterate. The second is to make keyframe validation check to only run if the model has already been compiled. I think this might be counter to the fix that was added for #2365, but shouldn't keyframes with joints from replicate tags still be valid?Confirmed it fixes the issue in the ticket, and the other user model tests pass. That said, I'm not sure what the larger consequences of this change are.