Skip to content

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Nov 16, 2024

TODO

BREAKING_CHANGE_REASON=Spanner v2

BEGIN_VERSION_OVERRIDE
Core: 1.68.0
END_VERSION_OVERRIDE

@bshaffer bshaffer mentioned this pull request Nov 16, 2024
5 tasks
@bshaffer bshaffer force-pushed the spanner-v2-refactor branch 2 times, most recently from fd840b9 to b01343c Compare November 20, 2024 20:42
@bshaffer bshaffer force-pushed the spanner-v2-refactor branch from 4dc7761 to a52f65c Compare February 20, 2025 18:26
@bshaffer bshaffer force-pushed the spanner-v2-owlbot-updates branch 2 times, most recently from 473a099 to 2cb8167 Compare April 28, 2025 20:22
@bshaffer bshaffer force-pushed the spanner-v2-refactor branch 2 times, most recently from 57510f6 to 2c33f61 Compare April 28, 2025 20:26
@bshaffer bshaffer force-pushed the spanner-v2-owlbot-updates branch from 2cb8167 to ea4cdcb Compare May 12, 2025 19:41
@bshaffer bshaffer force-pushed the spanner-v2-refactor branch 2 times, most recently from 2cc1634 to a324b05 Compare May 12, 2025 21:59
@bshaffer bshaffer force-pushed the spanner-v2-refactor branch from 691e07c to 82baba4 Compare July 9, 2025 16:23
@bshaffer bshaffer marked this pull request as ready for review July 9, 2025 16:24
@bshaffer bshaffer requested review from a team as code owners July 9, 2025 16:24
@bshaffer bshaffer requested a review from purva9413 July 18, 2025 17:46

// There isn't anything configurable here.
$options['transactionOptions'] = $this->configureTransactionOptions($options['transactionOptions'] ?? []);
$options['transactionOptions'] = $this->configureReadWriteTransactionOptions(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unusure of the call to configure the txn options here. If the $options['transactionOptions'] is set, this is essentially a no-op, and if this is not set it just initializes the readWrite options on the transactionOptions. We could add in a method to just init readWrite options (I have a similar suggestion in TransactionConfigurationTrait.php) and then simplify this with something like

$options['transactionOptions'] = $options['transactionOptions'] ?? $this->initReadWriteTransaction(); 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also help untangle some of the calling stack as there is a similar call to configure here as well.

Happy to discuss this in more details, I think our unit tests should be able to catch issues if they come up with this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've added calls using validateOptions to at least add structure to these functions.

@bshaffer bshaffer force-pushed the spanner-v2-refactor branch from db21d28 to ed9d000 Compare August 21, 2025 21:45
@bshaffer bshaffer requested review from a team as code owners August 22, 2025 18:29
@snippet-bot
Copy link

snippet-bot bot commented Aug 22, 2025

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer bshaffer force-pushed the spanner-v2-refactor branch from dd1e1ad to 05cdfb4 Compare August 22, 2025 18:48
@bshaffer bshaffer force-pushed the spanner-v2-refactor branch from 0bc1934 to 05cdfb4 Compare August 27, 2025 19:03
@bshaffer bshaffer added next release PRs to be included in the next release api: spanner Issues related to the Spanner API. v2 and removed next release PRs to be included in the next release labels Sep 30, 2025
Hectorhammett
Hectorhammett previously approved these changes Oct 10, 2025
Base automatically changed from spanner-v2-owlbot-updates to main October 10, 2025 21:54
@bshaffer bshaffer dismissed Hectorhammett’s stale review October 10, 2025 21:54

The base branch was changed.

@bshaffer bshaffer force-pushed the spanner-v2-refactor branch from 69c9dcf to b763b2b Compare October 13, 2025 18:02
@bshaffer bshaffer force-pushed the spanner-v2-refactor branch from c2bb1c3 to eae013d Compare October 13, 2025 19:09
@Hectorhammett Hectorhammett self-requested a review October 15, 2025 18:02
@bshaffer bshaffer merged commit bfc0dd6 into main Oct 15, 2025
43 checks passed
@bshaffer bshaffer deleted the spanner-v2-refactor branch October 15, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants