Skip to content

Conversation

@Xewar313
Copy link
Contributor

Adds some tests that check most basic command buffer functionalities

@Xewar313 Xewar313 requested review from a team as code owners February 25, 2025 13:07
@Xewar313 Xewar313 requested a review from EwanC February 25, 2025 13:07
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing these, especially the rect tests which can be tricky to write tests for.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could make these params const too, same in other new tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we might need a check "if driver version is older than add sync", because CI won't have a new enough version yet.

@Xewar313 Xewar313 requested a review from a team as a code owner May 5, 2025 08:49
@Xewar313 Xewar313 force-pushed the add-unified-runtime-tests branch from 7223e2e to 0f3fbd4 Compare May 5, 2025 09:00
@Xewar313 Xewar313 requested a review from pbalcer May 5, 2025 10:50
@pbalcer
Copy link
Contributor

pbalcer commented May 5, 2025

@intel/llvm-gatekeepers please merge

@kbenzie kbenzie merged commit 4681161 into intel:sycl May 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants