-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] [UR] Add command buffer operations tests #17159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
unified-runtime/test/conformance/exp_command_buffer/rect_read.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/test/conformance/exp_command_buffer/rect_read.cpp
Outdated
Show resolved
Hide resolved
cb60659 to
2f0cd00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing these, especially the rect tests which can be tricky to write tests for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could make these params const too, same in other new tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now we might need a check "if driver version is older than add sync", because CI won't have a new enough version yet.
7223e2e to
0f3fbd4
Compare
|
@intel/llvm-gatekeepers please merge |
Adds some tests that check most basic command buffer functionalities