add docs on how to use init-agent in an kcp-operator managed kcp#6
add docs on how to use init-agent in an kcp-operator managed kcp#6kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
Conversation
kcp-ci-bot
added
release-note-none
|
/retest |
SimonTheLeg
left a comment
SimonTheLeg
left a comment
There was a problem hiding this comment.
some small nits / questions from my side. Overall it looks pretty good :)
| * `configcluster` – This cluster is a workspace inside kcp where the `InitTargets` and `InitTemplates` | ||
| reside. This is kind of the "home" workspace for the init-agent, here it also performs its leader | ||
| election. | ||
| * `wstcluster` – This is also a workspace in kcp, but this cluster name stands for any workspace that |
There was a problem hiding this comment.
| * `wstcluster` – This is also a workspace in kcp, but this cluster name stands for any workspace that | |
| * `wstcluster` – This is an additional workspace in kcp, but this cluster name stands for any workspace that |
There was a problem hiding this comment.
I don't think we should call it "additional", since wstcluster and configcluster can be the same cluster, I do not want to give the impression that the wstcluster needs to be a second cluster.
docs/content/setup/production.md
Outdated
| namespace. For installing the init-agent, we now need to fetch the admin kubecofig (the first one): | ||
|
|
||
| ```bash | ||
| kubectl --namespace my-kcp get secret my-admin-kubeconfig --output json | |
There was a problem hiding this comment.
nit: no need for jq :)
kubectl --namespace my-kcp get secret my-admin-kubeconfig -o jsonpath="{.data.kubeconfig}" | base64 -d > kcp-admin.kubeconfig
There was a problem hiding this comment.
Nit: I hate typing JSONPaths in kubectl. I can never for the life of me remember if I have to -- for no actual reason -- wrap the JSONPath in curly braces or not. And if paths have to begin with a dot or not. And if it's -ojsonpath ... or -o jsonpath... or -o jsonpath ... or -o jsonpath=... or -o=jsonpath=... or -o "jsonpath=...".
The earlier I can nope out of kubectl and use something real, like jq, the better.
|
/approve |
|
LGTM label has been added. DetailsGit tree hash: 819f5ec9a8523d6ce6db1b2684aac113c716d3be |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SimonTheLeg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/retest I created #12 to track these surprisingly flaky e2e tests. |
|
/retest |
1 similar comment
|
/retest |
github-project-automation
bot
moved this from In-Review
to Done
in Platform Mesh & Kube Projects - Backlog
3 participants
Summary
This extends our documentation with a guide that more geared towards a production-like setup.
What Type of PR Is This?
/kind documentation
Release Notes