AP-23709: Fix deprecated box auth settings using CredentialsFlowVarChoicesProvider#43
Open
jannik-loescher-knime wants to merge 1 commit intomasterfrom
Open
Conversation
jannik-loescher-knime
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR updates the deprecated Box Authenticator node settings to use credential (username/password-style) fields instead of a credentials flow variable, aligning with the updated OAuth2 authenticator dialog behavior.
Changes:
- Replace the Box app “credentials flow variable” setting with a
LegacyCredentials-backed credentials widget plus migration/validation. - Add the required
@ValueReferencewiring so custom validation can reference theBoxAppSettingsparameter. - Update the dialog snapshot to reflect the new schema/model structure for the credentials widget.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| org.knime.ext.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAuthenticatorSettings.java | Adds @ValueReference(BoxAppSettings.Ref.class) to enable settings-level validation referencing. |
| org.knime.ext.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAppSettings.java | Migrates from flow-variable-based credentials selection to a credentials widget with migration + custom validation hook. |
| org.knime.ext.box.authenticator.tests/files/test_snapshots/org.knime.ext.box.authenticator.node.BoxAuthenticatorSettingsTest.snap | Updates snapshot for the new secret/legacyCredentials schema and update triggers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...xt.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAppSettings.java
Show resolved
Hide resolved
…oicesProvider AP-23709 (Support username and password fields instead of flow variables in OAuth2 Authenticator nodes)
jannik-loescher-knime
force-pushed
the
fix/remove-crednetials-provider-from-box-authenticator
branch
from
023589d to
1fa1f98
Compare
|
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AP-23709 (Support username and password fields instead of flow variables in OAuth2 Authenticator nodes)