Skip to content

Conversation

@yomybaby
Copy link
Member

@yomybaby yomybaby commented Jul 14, 2025

resolves #3880 (FR-1180)

Add Deployment Management UI

This PR adds a new Deployment Management UI to the WebUI, allowing users to create and manage model deployments. The implementation includes:

  • New deployment list page with filtering and pagination
  • Deployment detail page showing metadata and revisions
  • Revision creation with simple and expert modes
  • Revision detail page with autoscaling rules and trigger history
  • Traffic ratio management between revisions

The UI supports both simple preset-based deployments and expert mode with full configuration control.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC labels Jul 14, 2025
Copy link
Member Author

yomybaby commented Jul 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby force-pushed the feature/deployment-mockup-ui branch from 0c09377 to 176ff05 Compare July 14, 2025 23:40
@github-actions
Copy link

github-actions bot commented Jul 14, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.49% (-0.11% 🔻)
502/11192
🔴 Branches
3.65% (-0.05% 🔻)
285/7805
🔴 Functions
2.54% (-0.08% 🔻)
90/3543
🔴 Lines
4.45% (-0.11% 🔻)
488/10959
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / DeploymentCreatePage.tsx
0% 100% 0% 0%
🔴
... / DeploymentListPage.tsx
0% 0% 0% 0%
🔴
... / DeploymentDetailPage.tsx
0% 0% 0% 0%
🔴
... / RevisionCreatePage.tsx
0% 0% 0% 0%
🔴
... / RevisionDetailPage.tsx
0% 0% 0% 0%
🔴
... / DeploymentCreateModal.tsx
0% 0% 0% 0%
🔴
... / DeploymentList.tsx
0% 100% 0% 0%
🔴
... / DeploymentModeTag.tsx
0% 0% 0% 0%
🔴
... / DeploymentStatusTag.tsx
0% 0% 0% 0%
🔴
... / TrafficRatioSlider.tsx
0% 0% 0% 0%

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from aee2be0

@agatha197 agatha197 force-pushed the feature/deployment-mockup-ui branch 4 times, most recently from a0a1084 to cc95ea0 Compare August 13, 2025 14:39
@agatha197 agatha197 force-pushed the feature/deployment-mockup-ui branch 5 times, most recently from 3e99110 to 4beae81 Compare August 22, 2025 06:34
@agatha197 agatha197 changed the base branch from main to graphite-base/3947 August 22, 2025 07:28
@agatha197 agatha197 force-pushed the feature/deployment-mockup-ui branch from 4beae81 to 841aace Compare August 22, 2025 07:28
@agatha197 agatha197 changed the base branch from graphite-base/3947 to feat/bai-graphql-property-filter August 22, 2025 07:28
@yomybaby yomybaby changed the base branch from feat/bai-graphql-property-filter to graphite-base/3947 August 22, 2025 10:15
@agatha197 agatha197 force-pushed the feature/deployment-mockup-ui branch from 841aace to b910aca Compare August 22, 2025 14:10
@agatha197 agatha197 changed the base branch from graphite-base/3947 to feat/bai-graphql-property-filter August 22, 2025 14:11
@agatha197 agatha197 force-pushed the feature/deployment-mockup-ui branch from feb2175 to b69149c Compare August 27, 2025 11:36
@agatha197 agatha197 force-pushed the feat/bai-graphql-property-filter branch from 8cad22d to 484babf Compare August 27, 2025 11:36
@yomybaby yomybaby changed the base branch from feat/bai-graphql-property-filter to graphite-base/3947 August 28, 2025 03:37
@agatha197 agatha197 force-pushed the feature/deployment-mockup-ui branch from b69149c to 1c0d578 Compare August 28, 2025 06:05
@agatha197 agatha197 changed the base branch from graphite-base/3947 to feat/bai-graphql-property-filter August 28, 2025 06:05
@yomybaby yomybaby changed the base branch from feat/bai-graphql-property-filter to graphite-base/3947 September 1, 2025 10:09
@nowgnuesLee nowgnuesLee changed the title feat: Mockup UI for Deployment and Revisions feat(FR-1180): Mockup UI for Deployment and Revisions Sep 1, 2025
@nowgnuesLee nowgnuesLee marked this pull request as ready for review September 1, 2025 15:56
@agatha197 agatha197 force-pushed the feature/deployment-mockup-ui branch from 1c0d578 to 51cd3c7 Compare September 2, 2025 07:37
@agatha197 agatha197 changed the base branch from graphite-base/3947 to feat/bai-graphql-property-filter September 2, 2025 07:39
@nowgnuesLee nowgnuesLee changed the base branch from feat/bai-graphql-property-filter to graphite-base/3947 September 2, 2025 08:29
@graphite-app graphite-app bot force-pushed the feature/deployment-mockup-ui branch from 51cd3c7 to 8d388c9 Compare September 3, 2025 03:03
@graphite-app graphite-app bot force-pushed the graphite-base/3947 branch from c5bcbf9 to a2a70f9 Compare September 3, 2025 03:03
@graphite-app graphite-app bot changed the base branch from graphite-base/3947 to main September 3, 2025 03:03
@graphite-app graphite-app bot force-pushed the feature/deployment-mockup-ui branch from 8d388c9 to 108e579 Compare September 3, 2025 03:03
@ironAiken2 ironAiken2 force-pushed the feature/deployment-mockup-ui branch from 108e579 to aee2be0 Compare September 8, 2025 02:07
@Copilot Copilot AI review requested due to automatic review settings September 8, 2025 02:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive Deployment Management UI to the WebUI, allowing users to create and manage model deployments with both simple preset-based configurations and expert mode with full control. The implementation includes list, detail, and creation pages for deployments and revisions with features like traffic ratio management and autoscaling rules.

  • Adds new deployment management pages with CRUD operations for deployments and revisions
  • Implements two deployment modes: simple (preset-based) and expert (full configuration)
  • Includes traffic ratio management between deployment revisions

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/components/backend-ai-webui.ts Adds 'deployment' to available pages list
src/backend-ai-app.ts Adds deployment route handling and import
resources/i18n/en.json Adds comprehensive i18n strings for deployment and revision features
react/src/pages/Deployments/*.tsx Core deployment management pages with list, detail, and creation functionality
react/src/components/Deployments/*.tsx Reusable deployment UI components for status, mode, traffic management
react/src/components/MainLayout/WebUISider.tsx Adds deployment menu item to sidebar navigation
react/src/App.tsx Defines React router configuration for deployment pages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

key: 'metricSource',
},
{
title: t('revision.Condition'),
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation key 'revision.Condition' is used but not defined in the i18n file. This will result in missing translation text.

Copilot uses AI. Check for mistakes.
render: (_, row) => (
<BAIFlex direction="row" gap="xs">
<ResourceNumber type="cpu" value={row.total_cpu.toString()} />
<ResourceNumber type="mem" value={'12g'} />
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coded memory value '12g' should use actual data from the deployment object. Consider using row.total_mem or calculating from available data.

Suggested change
<ResourceNumber type="mem" value={'12g'} />
<ResourceNumber type="mem" value={row.total_mem.toString()} />

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reservoir mockup UI in WebUI

1 participant