-
Couldn't load subscription status.
- Fork 78
feat(FR-1405): version control of deployment features #4201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/FR-1416-add-deployment-select-component
Are you sure you want to change the base?
feat(FR-1405): version control of deployment features #4201
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.26% (-0.02% 🔻) |
505/11844 |
| 🔴 | Branches | 3.39% (-0.02% 🔻) |
285/8405 |
| 🔴 | Functions | 2.38% (-0.01% 🔻) |
90/3775 |
| 🔴 | Lines | 4.23% (-0.02% 🔻) |
491/11598 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / useRelayCursorPaginatedQuery.ts |
0% | 0% | 0% | 0% |
| 🔴 | ... / DeploymentSelect.tsx |
0% | 0% | 0% | 0% |
Test suite run success
114 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from f4ef420
35d2065 to
f5eb8fe
Compare
c833ff6 to
41ad6a3
Compare
41ad6a3 to
1cc9fa2
Compare
f5eb8fe to
abb83c3
Compare
abb83c3 to
07bcc5a
Compare
e63af79 to
58b6af9
Compare
07bcc5a to
b12818b
Compare
58b6af9 to
d717343
Compare
d717343 to
f4ef420
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to update this condition to 25.14.0, since it doesn't work with 25.13.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7fe69ce to
ca41b57
Compare
72a35d1 to
66bf5d3
Compare
ca41b57 to
1494c8e
Compare
1494c8e to
2e91cb6
Compare
66bf5d3 to
87937d5
Compare
2e91cb6 to
a7ec72a
Compare
87937d5 to
a1dfe2e
Compare

Resolves #4184 (FR-1405)
Add feature flag for deployment feature
This PR adds a feature flag for the deployment feature, making it available only when the manager version is compatible with 25.13.0 or later. The changes include:
@since(version: "25.13.0")directives to deployment GraphQL queriesChecklist: