Skip to content

Conversation

@agatha197
Copy link
Contributor

@agatha197 agatha197 commented Aug 27, 2025

Resolves #4184 (FR-1405)

Add feature flag for deployment feature

This PR adds a feature flag for the deployment feature, making it available only when the manager version is compatible with 25.13.0 or later. The changes include:

  1. Adding a 'deployment' feature flag in the client's feature detection
  2. Conditionally rendering the deployment menu item based on the feature flag
  3. Adding @since(version: "25.13.0") directives to deployment GraphQL queries

Checklist:

  • Minium required manager version: 25.13.0

Copy link
Contributor Author

agatha197 commented Aug 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Aug 27, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.26% (-0.02% 🔻)
505/11844
🔴 Branches
3.39% (-0.02% 🔻)
285/8405
🔴 Functions
2.38% (-0.01% 🔻)
90/3775
🔴 Lines
4.23% (-0.02% 🔻)
491/11598
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / useRelayCursorPaginatedQuery.ts
0% 0% 0% 0%
🔴
... / DeploymentSelect.tsx
0% 0% 0% 0%

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from f4ef420

@agatha197 agatha197 force-pushed the feat_FR-1416_/serving-page-to-deployment-page branch from 35d2065 to f5eb8fe Compare August 28, 2025 02:41
@agatha197 agatha197 force-pushed the feat_FR-1405_/version-control-of-deployments branch 2 times, most recently from c833ff6 to 41ad6a3 Compare August 28, 2025 02:53
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Aug 28, 2025
@agatha197 agatha197 changed the base branch from feat_FR-1416_/serving-page-to-deployment-page to graphite-base/4201 August 28, 2025 06:04
@agatha197 agatha197 force-pushed the feat_FR-1405_/version-control-of-deployments branch from 41ad6a3 to 1cc9fa2 Compare August 28, 2025 06:05
@agatha197 agatha197 changed the base branch from graphite-base/4201 to feat_FR-1391_/add-auto-scaling-rule August 28, 2025 06:05
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from abb83c3 to 07bcc5a Compare August 28, 2025 07:11
@agatha197 agatha197 force-pushed the feat_FR-1405_/version-control-of-deployments branch 2 times, most recently from e63af79 to 58b6af9 Compare August 28, 2025 07:17
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from 07bcc5a to b12818b Compare August 28, 2025 07:21
@agatha197 agatha197 force-pushed the feat_FR-1405_/version-control-of-deployments branch from 58b6af9 to d717343 Compare August 28, 2025 07:21
@agatha197 agatha197 changed the base branch from feat_FR-1391_/add-auto-scaling-rule to graphite-base/4201 August 29, 2025 05:06
@agatha197 agatha197 force-pushed the feat_FR-1405_/version-control-of-deployments branch from d717343 to f4ef420 Compare August 29, 2025 05:06
@agatha197 agatha197 changed the base branch from graphite-base/4201 to feat/FR-1416-add-deployment-select-component August 29, 2025 05:06
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to update this condition to 25.14.0, since it doesn't work with 25.13.0.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agatha197 agatha197 requested a review from yomybaby September 2, 2025 07:35
@agatha197 agatha197 force-pushed the feat/FR-1416-add-deployment-select-component branch from 7fe69ce to ca41b57 Compare September 2, 2025 07:37
@agatha197 agatha197 force-pushed the feat_FR-1405_/version-control-of-deployments branch 2 times, most recently from 72a35d1 to 66bf5d3 Compare September 2, 2025 07:39
@agatha197 agatha197 force-pushed the feat/FR-1416-add-deployment-select-component branch from ca41b57 to 1494c8e Compare September 2, 2025 07:39
@graphite-app graphite-app bot force-pushed the feat/FR-1416-add-deployment-select-component branch from 1494c8e to 2e91cb6 Compare September 3, 2025 03:06
@graphite-app graphite-app bot force-pushed the feat_FR-1405_/version-control-of-deployments branch from 66bf5d3 to 87937d5 Compare September 3, 2025 03:07
@agatha197 agatha197 force-pushed the feat/FR-1416-add-deployment-select-component branch from 2e91cb6 to a7ec72a Compare September 29, 2025 15:20
@agatha197 agatha197 force-pushed the feat_FR-1405_/version-control-of-deployments branch from 87937d5 to a1dfe2e Compare September 29, 2025 15:20
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:lib Library and SDK related issue. size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants