Skip to content

Conversation

@agatha197
Copy link
Contributor

@agatha197 agatha197 commented Aug 27, 2025

Resolves #4199 (FR-1391)

Add Auto Scaling Rule Management for Deployments

This PR adds UI components for managing auto scaling rules in model deployments:

  1. Created AutoScalingRuleList component to display existing auto scaling rules with columns for metric source, metric name, thresholds, step size, time window, replica limits, and timestamps.

  2. Added AutoScalingRuleSettingModal for creating and updating auto scaling rules with form fields for:

    • Metric source (Kernel or Inference Framework)
    • Metric name
    • Threshold settings (min/max)
    • Scaling settings (step size, time window)
    • Replica limits (min/max)
  3. Integrated these components into the DeploymentDetailPage with:

    • Auto scaling rules tab
    • Create/edit/delete functionality
    • Confirmation dialogs for deletions
  4. Updated i18n translations to support the new auto scaling rule UI elements.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

agatha197 commented Aug 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Aug 27, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.29% (-0.07% 🔻)
505/11779
🔴 Branches
3.41% (-0.07% 🔻)
285/8355
🔴 Functions
2.4% (-0.05% 🔻)
90/3757
🔴 Lines
4.26% (-0.07% 🔻)
491/11535
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / AutoScalingRuleList.tsx
0% 0% 0% 0%
🔴
... / AutoScalingRuleSettingModal.tsx
0% 0% 0% 0%
🔴
... / DeploymentDetailPage.tsx
0% 0% 0% 0%

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from b12818b

@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from 6e64f8a to 9c973b2 Compare August 27, 2025 11:36
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch from ad4568f to 049546a Compare August 27, 2025 11:36
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch 2 times, most recently from 9141575 to 1f9297d Compare August 27, 2025 11:58
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch from 049546a to 67fc52c Compare August 27, 2025 11:58
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch from 67fc52c to 1eded45 Compare August 27, 2025 23:35
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from 1f9297d to 2579fcb Compare August 27, 2025 23:35
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch from 1eded45 to 0fcddbd Compare August 28, 2025 02:41
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch 2 times, most recently from 3d1596f to abb83c3 Compare August 28, 2025 06:05
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch 2 times, most recently from 798a0c9 to 1e43668 Compare August 28, 2025 07:11
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch 2 times, most recently from 07bcc5a to b12818b Compare August 28, 2025 07:21
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch from 1e43668 to b703896 Compare August 28, 2025 07:21
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from b12818b to b2c6e44 Compare September 2, 2025 07:37
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch from b703896 to da8f467 Compare September 2, 2025 07:37
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from b2c6e44 to 2393796 Compare September 2, 2025 07:39
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch from da8f467 to 9eabd3c Compare September 2, 2025 07:39
@graphite-app graphite-app bot force-pushed the feat/FR-1407-deployment-action-buttons branch from 9eabd3c to 9bd309a Compare September 3, 2025 03:05
@graphite-app graphite-app bot force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from 2393796 to 82438bc Compare September 3, 2025 03:06
@agatha197 agatha197 force-pushed the feat/FR-1407-deployment-action-buttons branch from 9bd309a to 3214332 Compare September 29, 2025 15:20
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from 82438bc to 628b55b Compare September 29, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant