-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1420): add deployment select component and pagination hook #4210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat_FR-1391_/add-auto-scaling-rule
Are you sure you want to change the base?
feat(FR-1420): add deployment select component and pagination hook #4210
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.26% (-0.02% 🔻) |
505/11844 |
| 🔴 | Branches | 3.39% (-0.02% 🔻) |
285/8401 |
| 🔴 | Functions | 2.38% (-0.01% 🔻) |
90/3775 |
| 🔴 | Lines | 4.23% (-0.02% 🔻) |
491/11598 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / useRelayCursorPaginatedQuery.ts |
0% | 0% | 0% | 0% |
| 🔴 | ... / DeploymentSelect.tsx |
0% | 0% | 0% | 0% |
Test suite run success
114 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 7fe69ce
7fe69ce to
ca41b57
Compare
b12818b to
b2c6e44
Compare
ca41b57 to
1494c8e
Compare
b2c6e44 to
2393796
Compare
2393796 to
82438bc
Compare
1494c8e to
2e91cb6
Compare
2e91cb6 to
a7ec72a
Compare
82438bc to
628b55b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to need a restack.
| "RoutesInfo": "Routes Info", | ||
| "RoutingID": "Routing ID", | ||
| "ScalingSettings": "Scaling Settings", | ||
| "SelectDeployment": "Select Deployment", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the strings in the deployment object are not translated into other languages.

Resolves #4209 (FR-1420)
Add DeploymentSelect component with cursor-based pagination
This PR adds a new
DeploymentSelectcomponent for selecting deployments in the Chat interface. It includes:DeploymentSelect.tsxcomponent with search functionality and paginationuseRelayCursorPaginatedQueryhook for cursor-based pagination with RelayendpointUrlfilter to the GraphQL schema for deploymentsThe component provides a searchable dropdown with lazy-loading capabilities, displaying deployment names and allowing navigation to deployment details.
Checklist: