Skip to content

Conversation

@agatha197
Copy link
Contributor

@agatha197 agatha197 commented Aug 29, 2025

Resolves #4209 (FR-1420)

Add DeploymentSelect component with cursor-based pagination

This PR adds a new DeploymentSelect component for selecting deployments in the Chat interface. It includes:

  • A new DeploymentSelect.tsx component with search functionality and pagination
  • A new useRelayCursorPaginatedQuery hook for cursor-based pagination with Relay
  • Added endpointUrl filter to the GraphQL schema for deployments
  • Added translations for "Select Deployment" across all supported languages

The component provides a searchable dropdown with lazy-loading capabilities, displaying deployment names and allowing navigation to deployment details.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

agatha197 commented Aug 29, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 marked this pull request as ready for review August 29, 2025 05:06
@agatha197 agatha197 changed the title feat(FR-1416): add deployment select component and pagination hook feat(FR-1420): add deployment select component and pagination hook Aug 29, 2025
@github-actions
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.26% (-0.02% 🔻)
505/11844
🔴 Branches
3.39% (-0.02% 🔻)
285/8401
🔴 Functions
2.38% (-0.01% 🔻)
90/3775
🔴 Lines
4.23% (-0.02% 🔻)
491/11598
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / useRelayCursorPaginatedQuery.ts
0% 0% 0% 0%
🔴
... / DeploymentSelect.tsx
0% 0% 0% 0%

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 7fe69ce

@agatha197 agatha197 force-pushed the feat/FR-1416-add-deployment-select-component branch from 7fe69ce to ca41b57 Compare September 2, 2025 07:37
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from b12818b to b2c6e44 Compare September 2, 2025 07:37
@agatha197 agatha197 force-pushed the feat/FR-1416-add-deployment-select-component branch from ca41b57 to 1494c8e Compare September 2, 2025 07:39
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from b2c6e44 to 2393796 Compare September 2, 2025 07:39
@graphite-app graphite-app bot force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from 2393796 to 82438bc Compare September 3, 2025 03:06
@graphite-app graphite-app bot force-pushed the feat/FR-1416-add-deployment-select-component branch from 1494c8e to 2e91cb6 Compare September 3, 2025 03:06
@agatha197 agatha197 force-pushed the feat/FR-1416-add-deployment-select-component branch from 2e91cb6 to a7ec72a Compare September 29, 2025 15:20
@agatha197 agatha197 force-pushed the feat_FR-1391_/add-auto-scaling-rule branch from 82438bc to 628b55b Compare September 29, 2025 15:20
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to need a restack.

"RoutesInfo": "Routes Info",
"RoutingID": "Routing ID",
"ScalingSettings": "Scaling Settings",
"SelectDeployment": "Select Deployment",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the strings in the deployment object are not translated into other languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants