Skip to content

Conversation

@kjchee
Copy link
Contributor

@kjchee kjchee commented Aug 22, 2025

New feature implementation

Implemented feature

This PR is to support the new feature proposed at PR in rmf_task open-rmf/rmf_task#129

Implementation description

A new parameter in fleet_config.yaml (task_assignment_strategy) is read and passed to EasyFullControl and to FleetUpdateHandle and finally to TaskPlanner.

Also, for context, there are new functions added in rmf_task::State in rmf_task:

bool is_idle() const;
State& idle(bool is_idle);

purpose is to reflect whether the robot is in idle state, and so it can be set in TaskManager.cpp TaskManager::expected_finish_state(). Then this idle state will be stored in initial_states and passed to TaskPlanner via FleetUpdateHandle.cpp.

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Generated-by:

@mxgrey mxgrey moved this from Inbox to In Review in PMC Board Aug 26, 2025
@aaronchongth aaronchongth requested a review from mxgrey December 2, 2025 01:06
@aaronchongth aaronchongth moved this from In Review to Blocked in PMC Board Dec 2, 2025
@mxgrey mxgrey changed the title Feature/Support Idle Robot Preferred in Task Planning Customizable weights for task assignment cost Jan 12, 2026
@mxgrey mxgrey moved this from Blocked to In Review in PMC Board Jan 13, 2026
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. I've opened #501 as a reminder to add python bindings for these new settings, but I don't think that needs to block this PR.

@mxgrey mxgrey merged commit fac08c4 into open-rmf:main Jan 13, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in PMC Board Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (3be4edf) to head (744ae6f).
⚠️ Report is 169 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #466       +/-   ##
=========================================
- Coverage   17.61%      0   -17.62%     
=========================================
  Files         209      0      -209     
  Lines       19351      0    -19351     
  Branches     9297      0     -9297     
=========================================
- Hits         3409      0     -3409     
+ Misses      12274      0    -12274     
+ Partials     3668      0     -3668     
Flag Coverage Δ
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 209 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants