-
Notifications
You must be signed in to change notification settings - Fork 50
move providerbuilder to pkg/pf/internal #2804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
58a5829 to
d1f5261
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2804 +/- ##
==========================================
+ Coverage 68.70% 68.74% +0.03%
==========================================
Files 322 325 +3
Lines 41422 41536 +114
==========================================
+ Hits 28458 28552 +94
- Misses 11363 11379 +16
- Partials 1601 1605 +4 ☔ View full report in Codecov by Sentry. |
guineveresaenger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
|
This PR has been shipped in release v3.100.0. |
This is a pure refactor which moves the
providerbuildertest helper package frompkg/pf/tests/internaltopkg/pf/internalso that we can use it inpkg/pf/tfgenfor tests.