Skip to content

Conversation

@VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 2, 2025

This is a pure refactor which moves the providerbuilder test helper package from pkg/pf/tests/internal to pkg/pf/internal so that we can use it in pkg/pf/tfgen for tests.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Jan 2, 2025

@VenelinMartinov VenelinMartinov marked this pull request as draft January 2, 2025 15:35
@VenelinMartinov VenelinMartinov force-pushed the move-providerbuilder-to-pkg-pf branch from 58a5829 to d1f5261 Compare January 2, 2025 15:38
@VenelinMartinov VenelinMartinov requested review from a team and t0yv0 January 2, 2025 15:39
@VenelinMartinov VenelinMartinov marked this pull request as ready for review January 2, 2025 15:39
@codecov
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.74%. Comparing base (7550624) to head (d1f5261).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/pf/internal/providerbuilder/build_resource.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2804      +/-   ##
==========================================
+ Coverage   68.70%   68.74%   +0.03%     
==========================================
  Files         322      325       +3     
  Lines       41422    41536     +114     
==========================================
+ Hits        28458    28552      +94     
- Misses      11363    11379      +16     
- Partials     1601     1605       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@VenelinMartinov VenelinMartinov merged commit d9d48ae into master Jan 2, 2025
17 checks passed
@VenelinMartinov VenelinMartinov deleted the move-providerbuilder-to-pkg-pf branch January 2, 2025 17:11
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.100.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants