-
Notifications
You must be signed in to change notification settings - Fork 585
Load URDF with frame IDs #12005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MichaelGrupp
wants to merge
9
commits into
main
Choose a base branch
from
michael/urdf-tf-frame-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Load URDF with frame IDs #12005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
c6b5316 to
3f8f272
Compare
MichaelGrupp
commented
Dec 2, 2025
3f8f272 to
9d62a33
Compare
MichaelGrupp
commented
Dec 2, 2025
| // In order to move a joint, we just need to log a new transform between two of those frames. | ||
| rec.log( | ||
| link_path, | ||
| "/transforms", |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently not working if the URDF is logged together with the transforms. Waiting for "static-like" TF that can be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do-not-merge
Do not merge this PR
feat-dataloader
Everything related to data loaders
include in changelog
🪵 Log & send APIs
Affects the user-facing API for all languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoordinateFrames to link entities and visual/collision meshes, attach meshes viaTransform3Dto their linkTransform3D, with{parent, child}_frameconnecting a pair of linksNote:
base_link.animated_urdfworked until now... doesn't seem to be compatible with this change.Documentation will come separate (#12056)