Skip to content

Fix integral action for AntiWindupStrategy::NONE#432

Merged
christophfroehlich merged 4 commits intoros2-masterfrom
fix/pid
Jul 21, 2025
Merged

Fix integral action for AntiWindupStrategy::NONE#432
christophfroehlich merged 4 commits intoros2-masterfrom
fix/pid

Conversation

@christophfroehlich
Copy link
Copy Markdown
Member

There was no integral action with AntiWindupStrategy::NONE. Instead, it just should not saturate.

I fixed two other warning messages btw.

@christophfroehlich christophfroehlich added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Jul 21, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 21, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (ros2-master@c78e5e8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
control_toolbox/include/control_toolbox/pid.hpp 0.00% 1 Missing ⚠️
control_toolbox/src/pid.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             ros2-master     #432   +/-   ##
==============================================
  Coverage               ?   78.25%           
==============================================
  Files                  ?       30           
  Lines                  ?     1890           
  Branches               ?      114           
==============================================
  Hits                   ?     1479           
  Misses                 ?      342           
  Partials               ?       69           
Flag Coverage Δ
unittests 78.25% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
control_toolbox/include/control_toolbox/pid.hpp 65.09% <0.00%> (ø)
control_toolbox/src/pid.cpp 74.54% <66.66%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 4504fcf into ros2-master Jul 21, 2025
20 of 23 checks passed
@christophfroehlich christophfroehlich deleted the fix/pid branch July 21, 2025 20:59
mergify Bot pushed a commit that referenced this pull request Jul 21, 2025
christophfroehlich added a commit that referenced this pull request Jul 22, 2025
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants