Re-enable executor test on rmw_connextdds. #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It supports the events executor now, so re-enable the test. Signed-off-by: Chris Lalancette <[email protected]>
Contributor
Author
|
Pulls: #2693
|
fujitatomoya
approved these changes
Dec 3, 2024
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
sorry i missed this, now it support listener APIs.
Collaborator
|
@Mergifyio backport jazzy |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
It supports the events executor now, so re-enable the test. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit d724536)
fujitatomoya
pushed a commit
that referenced
this pull request
Dec 4, 2024
It supports the events executor now, so re-enable the test. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit d724536) Co-authored-by: Chris Lalancette <[email protected]>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
It supports the events executor now, so re-enable the test. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: HarunTeper <[email protected]>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
It supports the events executor now, so re-enable the test. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: HarunTeper <[email protected]>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
It supports the events executor now, so re-enable the test. Signed-off-by: Chris Lalancette <[email protected]>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Mar 3, 2025
It supports the events executor now, so re-enable the test. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: HarunTeper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It supports the events executor now, so re-enable the test.
This is follow-up to #2683 . @jmachowinski @fujitatomoya FYI