Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @rotem-starkware)


-- commits line 2 at r1:

Suggestion:

test deprecated_send_to_l1 scenario

crates/starknet_os_flow_tests/src/tests.rs line 1937 at r1 (raw file):

        from_address: test_contract_address,
        to_address: to_address.try_into().unwrap(),
        payload: L2ToL1Payload(vec![Felt::from(12), Felt::from(34)]),

Add a comment that these numbers come from the test contract.

Code quote:

[Felt::from(12), Felt::from(34)]

Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @rotem-starkware)


-- commits line 2 at r1:
NVM

@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_deprecated_send_to_l1_scenario branch from 03ccf0c to 690a255 Compare December 15, 2025 13:23
@dorimedini-starkware dorimedini-starkware changed the base branch from 12-08-starknet_os_flow_tests_migrate_test_single_empty_block_scenario to main-v0.14.1-committer December 15, 2025 13:23
@github-actions
Copy link

Artifacts upload workflows:

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @rotem-starkware and @yoavGrs)


crates/starknet_os_flow_tests/src/tests.rs line 1937 at r1 (raw file):

Previously, yoavGrs wrote…

Add a comment that these numbers come from the test contract.

Done.

@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_deprecated_send_to_l1_scenario branch from 690a255 to 7bf66d6 Compare December 16, 2025 08:14
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yoavGrs reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main-v0.14.1-committer with commit d855b4e Dec 16, 2025
21 of 23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants