-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_flow_tests: migrate test_deprecated_send_to_l1 scenario #10774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os_flow_tests: migrate test_deprecated_send_to_l1 scenario #10774
Conversation
yoavGrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoavGrs reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @rotem-starkware)
Suggestion:
test deprecated_send_to_l1 scenario
crates/starknet_os_flow_tests/src/tests.rs line 1937 at r1 (raw file):
from_address: test_contract_address, to_address: to_address.try_into().unwrap(), payload: L2ToL1Payload(vec![Felt::from(12), Felt::from(34)]),
Add a comment that these numbers come from the test contract.
Code quote:
[Felt::from(12), Felt::from(34)]
yoavGrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @rotem-starkware)
03ccf0c to
690a255
Compare
|
Artifacts upload workflows: |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @rotem-starkware and @yoavGrs)
crates/starknet_os_flow_tests/src/tests.rs line 1937 at r1 (raw file):
Previously, yoavGrs wrote…
Add a comment that these numbers come from the test contract.
Done.
690a255 to
7bf66d6
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoavGrs reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)
d855b4e

No description provided.