Skip to content

starknet_os_flow_tests: migrate test_replace_class scenario #10775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 1 commit into from
Dec 16, 2025
Merged

starknet_os_flow_tests: migrate test_replace_class scenario #10775

dorimedini-starkware merged 1 commit into from
Dec 16, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Dec 15, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 15, 2025

This change is Reviewable

@dorimedini-starkware dorimedini-starkware mentioned this pull request Dec 15, 2025
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Dec 15, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 15, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware self-assigned this Dec 15, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review December 15, 2025 08:48
yoavGrs
yoavGrs approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yoavGrs reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @rotem-starkware)

-- commits line 2 at r1:

Suggestion:

migrate test replace_class_scenario

yoavGrs
yoavGrs approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @rotem-starkware)

-- commits line 2 at r1:
NVM

@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_deprecated_send_to_l1_scenario branch from 03ccf0c to 690a255 Compare December 15, 2025 13:23
@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_replace_class_scenario branch from b39ebcb to 62c9c20 Compare December 15, 2025 13:23
dorimedini-starkware
dorimedini-starkware commented Dec 15, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_deprecated_send_to_l1_scenario branch from 690a255 to 7bf66d6 Compare December 16, 2025 08:14
@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_replace_class_scenario branch from 62c9c20 to 8941274 Compare December 16, 2025 08:14
dorimedini-starkware
dorimedini-starkware commented Dec 16, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)

@dorimedini-starkware dorimedini-starkware changed the base branch from 12-08-starknet_os_flow_tests_migrate_test_deprecated_send_to_l1_scenario to main-v0.14.1-committer December 16, 2025 08:31
@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_replace_class_scenario branch from 8941274 to 9be01d3 Compare December 16, 2025 08:32
@graphite-app
Copy link

graphite-app bot commented Dec 16, 2025

Merge activity

  • Dec 16, 8:32 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main-v0.14.1-committer with commit 0d1d03e Dec 16, 2025
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yoavGrs yoavGrs yoavGrs approved these changes

@rotem-starkware rotem-starkware Awaiting requested review from rotem-starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @yoavGrs