Skip to content

starknet_os_flow_tests: migrate test_deprecated_call_contract_variants scenario #10779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 6 commits into from
Dec 16, 2025
Merged

starknet_os_flow_tests: migrate test_deprecated_call_contract_variants scenario #10779

dorimedini-starkware merged 6 commits into from
Dec 16, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Dec 15, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 15, 2025

This change is Reviewable

This was referenced Dec 15, 2025
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Dec 15, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 15, 2025
Merged
Merged
@dorimedini-starkware dorimedini-starkware self-assigned this Dec 15, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review December 15, 2025 08:49
@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_deprecated_call_contract_variants_scenario branch from f71eca6 to 0985aed Compare December 15, 2025 10:51
@github-actions
Copy link

github-actions bot commented Dec 15, 2025 •
edited
Loading

Artifacts upload workflows:

Yoni-Starkware
Yoni-Starkware requested changes Dec 15, 2025
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 11 of 12 files at r1, all commit messages.
Reviewable status: 11 of 12 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @rotem-starkware, and @yoavGrs)

crates/starknet_os_flow_tests/src/tests.rs line 524 at r1 (raw file):

#[rstest]
#[tokio::test]
async fn test_deprecated_call_contract_variants() {

Is it supposed to cover deprecated_call_contract_variants_scenario?
What about the library calls?

@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_getter_syscalls_scenario branch from d4d9756 to 0a70847 Compare December 15, 2025 13:24
@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_deprecated_call_contract_variants_scenario branch from 0985aed to c20a52f Compare December 15, 2025 13:24
dorimedini-starkware
dorimedini-starkware commented Dec 15, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 12 files reviewed, 1 unresolved discussion (waiting on @rotem-starkware, @yoavGrs, and @Yoni-Starkware)

crates/starknet_os_flow_tests/src/tests.rs line 524 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Is it supposed to cover deprecated_call_contract_variants_scenario?
What about the library calls?

we run those here

@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_getter_syscalls_scenario branch from 0a70847 to d9bde9c Compare December 15, 2025 13:29
@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_deprecated_call_contract_variants_scenario branch from c20a52f to 9fa8efe Compare December 15, 2025 13:29
Yoni-Starkware
Yoni-Starkware approved these changes Dec 15, 2025
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware and @yoavGrs)

@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_getter_syscalls_scenario branch from d9bde9c to 07842fb Compare December 16, 2025 08:14
@dorimedini-starkware dorimedini-starkware force-pushed the 12-08-starknet_os_flow_tests_migrate_test_deprecated_call_contract_variants_scenario branch from 9fa8efe to 729fe2c Compare December 16, 2025 08:14
dorimedini-starkware
dorimedini-starkware commented Dec 16, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware and @yoavGrs)

@dorimedini-starkware dorimedini-starkware changed the base branch from 12-08-starknet_os_flow_tests_migrate_getter_syscalls_scenario to main-v0.14.1-committer December 16, 2025 09:57
dorimedini-starkware
dorimedini-starkware commented Dec 16, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware and @yoavGrs)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main-v0.14.1-committer with commit 5bd5cd9 Dec 16, 2025
40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@rotem-starkware rotem-starkware Awaiting requested review from rotem-starkware

@yoavGrs yoavGrs Awaiting requested review from yoavGrs

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @Yoni-Starkware