starknet_os_flow_tests: migrate test_deploy_no_ctor_contract scenario #10777
Conversation
|
This change is |
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @rotem-starkware)
crates/starknet_os_flow_tests/src/tests.rs line 2967 at r1 (raw file):
#[rstest] #[tokio::test] async fn test_deploy_no_ctor_contract() {
Doc the test, as in the python repo
dorimedini-starkware
force-pushed
the
12-08-starknet_os_flow_tests_migrate_test_ec_op_scenario
branch
from
605340d to
49db718
Compare
dorimedini-starkware
force-pushed
the
12-08-starknet_os_flow_tests_migrate_test_deploy_no_ctor_contract_scenario
branch
2 times, most recently
from
01bb702 to
fcdacbb
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @rotem-starkware and @yoavGrs)
crates/starknet_os_flow_tests/src/tests.rs line 2967 at r1 (raw file):
Previously, yoavGrs wrote…
Doc the test, as in the python repo
Done.
dorimedini-starkware
force-pushed
the
12-08-starknet_os_flow_tests_migrate_test_ec_op_scenario
branch
from
49db718 to
4577ae9
Compare
dorimedini-starkware
force-pushed
the
12-08-starknet_os_flow_tests_migrate_test_deploy_no_ctor_contract_scenario
branch
from
fcdacbb to
e67b3c4
Compare
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)
dorimedini-starkware
changed the base branch from
12-08-starknet_os_flow_tests_migrate_test_ec_op_scenario
to
main-v0.14.1-committer
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
No description provided.