Skip to content

Conversation

@guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Feb 10, 2026

Note

Low Risk
Small, mostly type-level API change; risk is limited to potential downstream compile fixes where BadPeerReport.reason was previously treated as a String.

Overview
Introduces a typed BadPeerReason enum for BadPeerReport.reason (replacing the raw String), allowing callers to distinguish between conversion errors and duplicate-vote misconduct.

Removes the #[allow(dead_code)] attribute on consensus’s DuplicateVoteReport, making unused-report detection stricter as duplicate-vote reporting gets wired up.

Written by Cursor Bugbot for commit 826ed3e. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

guy-starkware commented Feb 10, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants