Skip to content

Conversation

@guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Feb 10, 2026

Note

Medium Risk
Touches consensus network message handling and changes how future votes are cached/reported, which could affect peer reporting behavior and cache contents under real network conditions.

Overview
Adds duplicate detection when caching future-height votes: ConsensusCache::cache_future_vote now de-duplicates by (vote_type, round, voter), silently ignoring identical repeats while returning a DuplicateVoteReport for conflicting votes.

MultiHeightManager::handle_vote uses this report to log a warning and report_peer on equivocation attempts, and a new test cache_future_vote_deduplication asserts that identical duplicates do not trigger reporting while conflicting duplicates do.

Written by Cursor Bugbot for commit 3703184. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

guy-starkware commented Feb 10, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants