apollo_consensus: check for duplicate votes before caching #12465
+112
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches consensus network message handling and changes how future votes are cached/reported, which could affect peer reporting behavior and cache contents under real network conditions.
Overview
Adds duplicate detection when caching future-height votes:
ConsensusCache::cache_future_votenow de-duplicates by(vote_type, round, voter), silently ignoring identical repeats while returning aDuplicateVoteReportfor conflicting votes.MultiHeightManager::handle_voteuses this report to log a warning andreport_peeron equivocation attempts, and a new testcache_future_vote_deduplicationasserts that identical duplicates do not trigger reporting while conflicting duplicates do.Written by Cursor Bugbot for commit 3703184. This will update automatically on new commits. Configure here.