Skip to content

Conversation

@guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Feb 10, 2026

Note

Medium Risk
Touches cross-crate networking interfaces and call sites; behavior should be equivalent but signature changes and new report construction could break integrations or misclassify peers if wired incorrectly.

Overview
Updates the broadcast peer-reporting API so BroadcastTopicClientTrait::report_peer now requires a BadPeerReport (peer id, BadPeerReason, and PenaltyCard) alongside the original BroadcastedMessageMetadata.

Consensus and mempool P2P are updated to construct and pass structured reports for specific cases (e.g., vote/tx conversion failures and duplicate votes), tests/mocks are adjusted accordingly, and the network crate docs/tests are updated; the current BroadcastTopicClient::report_peer still only forwards the metadata while logging the report (TODO to send it).

Written by Cursor Bugbot for commit a921ad3. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants